Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated access key of the prev and next buttons when prev_next_buttons_location == 'both' #1057

Open
SuperPat45 opened this issue Feb 23, 2021 · 1 comment
Labels
Accepted Accepted issue on our roadmap Bug A bug Good First Issue Good for new contributors

Comments

@SuperPat45
Copy link

SuperPat45 commented Feb 23, 2021

Problem

The Chrome Lighthouse auditor report some accessibility problems;
_ Color contrast problems in the lateral nav bar
_ Missing aria-label in the input search box
_ Duplicated access key of the previous and next buttons when variable theme_prev_next_buttons_location == 'both'

Reproducible Project

The first two are available in all rtd doc like: https://sphinx-rtd-theme.readthedocs.io/en/latest/
The third one need variable theme_prev_next_buttons_location == 'both'

Expected Results

Improve Chrome Lighthouse audit score

@SuperPat45 SuperPat45 changed the title Fix accessibilittt problem reported by the Chrome Lighthouse audit Fix accessibility problem reported by the Chrome Lighthouse audit Feb 23, 2021
@SuperPat45 SuperPat45 changed the title Fix accessibility problem reported by the Chrome Lighthouse audit Fix accessibility problems reported by the Chrome Lighthouse audit Feb 23, 2021
@stsewd
Copy link
Member

stsewd commented Feb 24, 2021

Hi, thanks for the report, some of these are already reported:

The third one I don't think it has been reported before.

@stsewd stsewd changed the title Fix accessibility problems reported by the Chrome Lighthouse audit Duplicated access key of the prev and next buttons when prev_next_buttons_location == 'both' Feb 24, 2021
@stsewd stsewd added Accepted Accepted issue on our roadmap Bug A bug labels Feb 24, 2021
@Blendify Blendify added the Good First Issue Good for new contributors label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug Good First Issue Good for new contributors
Projects
None yet
Development

No branches or pull requests

3 participants