-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme option flyout
to enable/disable theme's flyout
#1580
Conversation
Add a theme option to enable/disable the theme's flyout integrated at the bottom left into the navigation bar. Closes #1579
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving users this control makes sense 👍
I think the configuration option name and values could be tuned to be more clear though.
We talked about
|
I made this changes. @agjohnson let me know if this is ready to get merged. After merging it, I will release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Add a theme option to enable/disable the theme's flyout integrated at the bottom left into the navigation bar.
Closes #1579