Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme option flyout to enable/disable theme's flyout #1580

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 31, 2024

Add a theme option to enable/disable the theme's flyout integrated at the bottom left into the navigation bar.

Closes #1579

Add a theme option to enable/disable the theme's flyout integrated at the bottom
left into the navigation bar.

Closes #1579
@humitos humitos requested a review from a team as a code owner July 31, 2024 14:47
@humitos humitos mentioned this pull request Jul 31, 2024
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving users this control makes sense 👍

I think the configuration option name and values could be tuned to be more clear though.

docs/configuring.rst Outdated Show resolved Hide resolved
@humitos humitos requested a review from agjohnson August 7, 2024 10:59
@humitos
Copy link
Member Author

humitos commented Aug 7, 2024

We talked about

  • Making the default behavior to be hidden by default.
  • Integrate the version and language selector in the theme itself -- outside the flyout concept -- is a good goal for 4.0.

@humitos
Copy link
Member Author

humitos commented Aug 8, 2024

I made this changes. @agjohnson let me know if this is ready to get merged. After merging it, I will release 2.1.0rc2

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

docs/configuring.rst Show resolved Hide resolved
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@humitos humitos merged commit a359d40 into master Aug 14, 2024
7 of 8 checks passed
@humitos humitos deleted the humitos/theme-flyout-conf branch August 14, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add theme option to disable theme's flyout
3 participants