Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Bug in *_wrap_and_apply_header() in generated C code #822

Closed
danielcranford opened this issue Nov 6, 2020 · 2 comments · Fixed by #821
Closed

[C] Bug in *_wrap_and_apply_header() in generated C code #822

danielcranford opened this issue Nov 6, 2020 · 2 comments · Fixed by #821

Comments

@danielcranford
Copy link
Contributor

Generated C code has a bug in the generated function *_wrap_and_apply_header() The argument order when it calls *messageHeader__wrap() is wrong. It seems like an easy mistake to make as there is very little consistency in argument order between version and bufferLength in the generated code.

@mjpt777
Copy link
Contributor

mjpt777 commented Nov 10, 2020

I agree there is a consistency issue here. @denizevrenci should we make these consistent within the C codecs and make it consistent with the C++ codecs?

@denizevrenci
Copy link
Contributor

Sorry for the late response. It seems like the issue is already resolved but I am also in favor of keeping consistency with the C++ codecs as C codecs were originally modeled from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants