Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated messages should result in their en/decoders marked with @Deprecated #875

Closed
ratcashdev opened this issue Nov 10, 2021 · 1 comment
Closed

Deprecated messages should result in their en/decoders marked with @Deprecated #875

ratcashdev opened this issue Nov 10, 2021 · 1 comment

Comments

@ratcashdev
Copy link
Contributor

given a definition like

<sbe:message name="MyDeprecatedMessage" id="123"
    description="old message that was deprecated in version 45" deprecated="45">

its respective java encoder and decoder should be marked with the @Deprecated annotation so that users get compile time warnings when still using old messages.

Happy to submit a PR, if this issue and objectives are accepted.
@mjpt777
Copy link
Contributor

mjpt777 commented Nov 10, 2021

I'd be happy to review an PR on this.

@ratcashdev ratcashdev mentioned this issue Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vyazelenko @mjpt777 @ratcashdev