Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "Enable background slideshows" under General skin settings #45

Closed
TheOne988 opened this issue Aug 3, 2023 · 4 comments
Closed

Comments

@TheOne988
Copy link

In the latest version 1.1.7 the option to enable or disable the background slideshow is missing.

image

FIX for the issue:
The file skin.copacetic/16x9/Content_Settings.xml is missing a whole Enable background fanart slideshow control button. It should be returned as in previous versions:

<control type="radiobutton" id="1017">
	<description>Enable background fanart slideshow</description>
	<visible>ControlGroup(9).HasFocus(10)</visible>
	<label>$LOCALIZE[31425]</label>
	<onclick>Skin.ToggleSetting(Background_Disabled)</onclick>
	<selected>!Skin.HasSetting(Background_Disabled)</selected>
</control> 
@realcopacetic
Copy link
Owner

The reason I removed this was because it was getting very complicated supporting the various permeations of the light and dark themes so I just wanted to simplify because the design intention is that those screens would have a background image instead of being blank.

Do you want the ability to disable for aesthetic or performance reasons? I tried to ensure that the impact would be as minimal as possible. The background script only fetches artwork when a window with the slideshow is visible, otherwise it is paused.

@TheOne988
Copy link
Author

Hi @realcopacetic,

I didn't think that the option was removed on purpose that why I reported it.
I think that performance is not the key factor because if you are using the art slideshow on the homepage it is not going to make some difference.
From a personal opinion I prefer to have some generic color or background when I'm in the menu browsing for some settings. The displayed art can sometimes be very bright or colorful and can interfere with the text from the menus.
I really don't know how complicated it is to support this because I have no experience in building Kodi skins.

Maybe it is even simpler if it doesn't show the art slideshow in the settings menus basically to hardcore some background/color. But as I said above I'm not an expert so I cannot know for sure if this suggestion is going to be simpler or not.

Anyway keep up the good work. I really like your skin that is why I report everything I find so I can use it without any hiccups 😊

@realcopacetic
Copy link
Owner

I'll have a think about this. one idea is to have the option for a solid colour panel on top of the artwork or an option to dim it more if readability is an issue

@realcopacetic
Copy link
Owner

Added ability to edit opacity of background panels in 1.1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants