Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Request] Conditional checks itselft #2061

Closed
masters3d opened this issue Feb 23, 2018 · 2 comments
Closed

[Rule Request] Conditional checks itselft #2061

masters3d opened this issue Feb 23, 2018 · 2 comments
Labels
duplicate Issues that already exist in other terms.

Comments

@masters3d
Copy link
Contributor

Rule Request

  1. Why should this rule be added? Share links to existing discussion about what
    the community thinks about this.
    Rule request: No explicit == true or == false #1502 (comment)

  2. Provide several examples of what would and wouldn't trigger violations.

if someObj == someObj {} // always true
if objA != objA {} // always false

This would not trigger even though they might have the same value. :

let someObj2 = someObj 
if someObj2 == someObj {} // always true
  1. Should the rule be configurable, if so what parameters should be configurable?
    probably not.

  2. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a
    rule as opt-in.
    Probably Default if fast enough.

@marcelofabri
Copy link
Collaborator

Duplicate of #1371?

@masters3d
Copy link
Contributor Author

ha! totally, I just could not find it.

@marcelofabri marcelofabri added the duplicate Issues that already exist in other terms. label Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues that already exist in other terms.
Projects
None yet
Development

No branches or pull requests

2 participants