Adds NSError to the list of types in discouraged_direct_init

[jszumski]

Fixes #4507.

Using NSError() at runtime shows this warning and should be discouraged:

-[NSError init] called; this results in an invalid NSError instance. It will raise an exception in a future release. Please call errorWithDomain:code:userInfo: or initWithDomain:code:userInfo:. This message shown only once.

[jpsim]

Thanks for the PR and the detailed rationale, looks good!

Can you please add a changelog entry following the format described in https://github.com/realm/SwiftLint/blob/main/CONTRIBUTING.md#tracking-changes ?

[SwiftLintBot]

	18 Warnings
⚠️	This PR introduced a violation in Firefox: /Account/SyncAuthState.swift:147:71: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in Firefox: /Sync/SyncStateMachine.swift:150:100: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in Kickstarter: /Library/PaginateTests.swift:241:29: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Gutenberg/EditorMediaUtility.swift:158:43: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Gutenberg/EditorMediaUtility.swift:165:43: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/PostCoordinatorTests.swift:124:110: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/PostCoordinatorTests.swift:27:110: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/PostCoordinatorTests.swift:369:110: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/PostCoordinatorTests.swift:406:69: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:106:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:139:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:152:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:164:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:175:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:53:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:65:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/RegisterDomainDetailsServiceProxyMock.swift:90:21: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressTest/ShareAppContentPresenterTests.swift:144:49: warning: Discouraged Direct Initialization Violation: Discouraged direct initialization of types that can be harmful. (discouraged_direct_init)

	18 Messages
📖	Linting Aerial with this PR took 1.43s vs 1.43s on main (0% slower)
📖	Linting Alamofire with this PR took 2.05s vs 2.04s on main (0% slower)
📖	Linting Brave with this PR took 9.93s vs 9.95s on main (0% faster)
📖	Linting DuckDuckGo with this PR took 4.14s vs 4.12s on main (0% slower)
📖	Linting Firefox with this PR took 9.05s vs 9.02s on main (0% slower)
📖	Linting Kickstarter with this PR took 14.99s vs 14.95s on main (0% slower)
📖	Linting Moya with this PR took 0.95s vs 0.95s on main (0% slower)
📖	Linting NetNewsWire with this PR took 4.14s vs 4.14s on main (0% slower)
📖	Linting Nimble with this PR took 0.88s vs 0.91s on main (3% faster)
📖	Linting PocketCasts with this PR took 15.4s vs 15.02s on main (2% slower)
📖	Linting Quick with this PR took 0.29s vs 0.28s on main (3% slower)
📖	Linting Realm with this PR took 16.89s vs 16.96s on main (0% faster)
📖	Linting SourceKitten with this PR took 0.56s vs 0.57s on main (1% faster)
📖	Linting Sourcery with this PR took 3.59s vs 3.57s on main (0% slower)
📖	Linting Swift with this PR took 6.36s vs 6.36s on main (0% slower)
📖	Linting VLC with this PR took 1.7s vs 1.69s on main (0% slower)
📖	Linting Wire with this PR took 18.29s vs 19.32s on main (5% faster)
📖	Linting WordPress with this PR took 14.03s vs 13.95s on main (0% slower)

Generated by 🚫 Danger

[jszumski]

Updated CHANGELOG.md 👍