Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new Quick APIs aroundEach and justBeforeEach #4626

Closed
2 tasks done
stonko1994 opened this issue Dec 7, 2022 · 0 comments · Fixed by #4627
Closed
2 tasks done

Allow new Quick APIs aroundEach and justBeforeEach #4626

stonko1994 opened this issue Dec 7, 2022 · 0 comments · Fixed by #4627
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@stonko1994
Copy link
Contributor

New Issue Checklist

Describe the bug

Quick 5.0.0 introduced aroundEach and Quick 6.0.0 introduced justBeforeEach. Both are currently flagged as violations for quick_discouraged_call.

Complete output when running SwiftLint, including the stack trace and command used
$ swiftlint lint
⚠️ Line xxx: Discouraged call inside a 'describe' block.

Environment

  • SwiftLint version (run swiftlint version to be sure)? 0.50.1
  • Installation method used (Homebrew, CocoaPods, building from source, etc)? Homebrew
  • Paste your configuration file: N/A
// This triggers a violation:
describe("foo") {
    justBeforeEach {
        ...
    }
}
@SimplyDanny SimplyDanny added the enhancement Ideas for improvements of existing features and rules. label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants