Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a standalone repo for the SwiftLint plugins #5750

Closed
2 tasks done
BrentMifsud opened this issue Aug 12, 2024 · 4 comments
Closed
2 tasks done

Create a standalone repo for the SwiftLint plugins #5750

BrentMifsud opened this issue Aug 12, 2024 · 4 comments
Labels
discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. integration Issues related to integration of SwiftLint into toolchains.

Comments

@BrentMifsud
Copy link

New Issue Checklist

Feature or Enhancement Proposal

With the addition of macros to the swift language, many dependencies now rely on swift syntax. Some of which conflict with the version of swift syntax that SwiftLint is using.

Here is an example issue: lukepistrol/SFSymbolsMacro#4

It would be nice if there was an official SwiftLint plugin repo, rather than having to rely on third parties to make one (like mentioned in the issue I linked above)

@SimplyDanny
Copy link
Collaborator

It would be nice if there was an official SwiftLint plugin repo, rather than having to rely on third parties to make one (like mentioned in the issue I linked above)

This is an interesting point. What would you call a "third party" in an open source project?

SwiftLint is not managed by a company but by people maintaining it as a hobby. If you rely on OSS, you rely on the people defining it. In this specific case, that's me providing SwiftLintPlugins as a binary version of the plugins. The repository is fully synced with the main SwiftLint repository and its releases. You actually won't get something more "official" right now. At least I don't know who you ask to provide that.

@SimplyDanny SimplyDanny added discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. integration Issues related to integration of SwiftLint into toolchains. labels Aug 12, 2024
@BrentMifsud
Copy link
Author

It would be nice if there was an official SwiftLint plugin repo, rather than having to rely on third parties to make one (like mentioned in the issue I linked above)

This is an interesting point. What would you call a "third party" in an open source project?

SwiftLint is not managed by a company but by people maintaining it as a hobby. If you rely on OSS, you rely on the people defining it. In this specific case, that's me providing SwiftLintPlugins as a binary version of the plugins. The repository is fully synced with the main SwiftLint repository and its releases. You actually won't get something more "official" right now. At least I don't know who you ask to provide that.

Is there any automation in place to ensure that the SwiftLintPlugins repo does not become out of sync with the main swiftlint repo?

I guess that's my only hesitation.

@SimplyDanny
Copy link
Collaborator

There is one workflow that syncs the Plugins directory whenever there is a change on any of the files in there. Another workflow creates a matching release in SwiftLintPlugins with the data used to create a release in SwiftLint. With that, there is nothing to do in the plugin repository itself. It's basically a mirror. Only an outdated token has the potential to cause trouble.

@BrentMifsud
Copy link
Author

Awesome. Thanks for the info.

@SimplyDanny SimplyDanny closed this as not planned Won't fix, can't repro, duplicate, stale Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Topics that cannot be categorized as bugs or enhancements yet. They require further discussions. integration Issues related to integration of SwiftLint into toolchains.
Projects
None yet
Development

No branches or pull requests

3 participants
@SimplyDanny @BrentMifsud and others