Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling 'cancel_waits_on_nonfatal_error' does not cancel waits during location update while offline #7527

Closed
sync-by-unito bot opened this issue Mar 27, 2024 · 2 comments · Fixed by #7528
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 27, 2024

The errors being reported by the sync sessions while offline were fixed as part of RCORE-1982, however, the operation of the cancel_waits_on_nonfatal_error configuration was not allowing the location update to exit early if enabled and the client was offline.

This flag is used by the AutoOpen realms in the Swift SDK, but there currently isn't a test in Core to verify it's operation.

Fix the operation of the flag and add tests to confirm its operation.

Copy link
Author

sync-by-unito bot commented Mar 27, 2024

➤ PM Bot commented:

Jira ticket: RCORE-2060

Copy link
Author

sync-by-unito bot commented May 2, 2024

➤ michael-wb commented:

This change has been merged to master - once it has been integrated into a Swift release, confirm with the customer(s) regarding the fixes for RCOCOA-2280 and RCOCOA-2324

@sync-by-unito sync-by-unito bot closed this as completed May 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant