Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to OpenSSL 3.3.1 #7947

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Upgrade to OpenSSL 3.3.1 #7947

merged 3 commits into from
Aug 9, 2024

Conversation

fealebenpae
Copy link
Member

@fealebenpae fealebenpae commented Aug 2, 2024 •
edited
Loading

☑️ ToDos

  • 📝 Changelog update

@fealebenpae fealebenpae self-assigned this Aug 2, 2024
@cla-bot cla-bot bot added the cla: yes label Aug 2, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build yavor.georgiev_449

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 85 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.085%
Files with Coverage Reduction New Missed Lines %
src/realm/mixed.cpp 1 86.46%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/array_blobs_big.cpp 2 98.58%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/sync/network/network.cpp 3 87.95%
src/realm/sync/noinst/client_impl_base.cpp 3 82.78%
src/realm/sync/noinst/protocol_codec.hpp 3 74.0%
src/realm/table.cpp 3 90.59%
src/realm/sync/noinst/server/server.cpp 5 73.65%
src/realm/sync/instruction_applier.cpp 12 68.01%
Totals Coverage Status
Change from base Build 2537: -0.02%
Covered Lines: 216777
Relevant Lines: 237995
💛 - Coveralls

@fealebenpae fealebenpae mentioned this pull request Aug 5, 2024
Open
jbreams
jbreams reviewed Aug 5, 2024
View reviewed changes
CHANGELOG.md

### Fixed
* <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?)
* None.
* Fixed issues loading the native Realm libraries on Linux ARMv7 systems when they linked against our bundled OpenSSL resulting in errors like `unexpected reloc type 0x03`. ([#7947](https://github.com/realm/realm-core/issues/7947), since v14.1.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this resolved just by not forcing the bfd linker or were there other fixes in openssl that fixed this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an upstream patch that hides the unrelocable symbol that was giving us trouble on armv7. I just removed the bfd workaround because it is no longer necessary.

@fealebenpae fealebenpae merged commit 05805d7 into master Aug 9, 2024
3 of 5 checks passed
@fealebenpae fealebenpae deleted the yg/openssl branch August 9, 2024 09:11
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbreams jbreams jbreams approved these changes

Assignees

@fealebenpae fealebenpae

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fealebenpae @jbreams