Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USE_HARDWARESERIAL per default for ESP32 #73

Closed
Adminius opened this issue Feb 14, 2023 · 1 comment
Closed

USE_HARDWARESERIAL per default for ESP32 #73

Adminius opened this issue Feb 14, 2023 · 1 comment

Comments

@Adminius
Copy link
Contributor

Hi, I'm trying to integrate your lib into OpenDTU.
I would like platform.io let collect your library directly from github.
That means, that I can't modify SDM_Config_User.h
It produces complie error: SoftwareSerial.h is not found. It is because there is no integrated SW Serial for ESP32 like for ESP8266.
So, because ESP32 has 3x HW and there is no standard SW Serial lib, it make sense to change some ifdefs to use HW-Serial on ESP32 per default.
I think the easiest way is to add before this line
https://github.com/reaper7/SDM_Energy_Meter/blob/master/SDM.h#L12

#if defined ( ESP32 )
#define USE_HARDWARESERIAL 
#endif

same here: ESP32 and SW-Serial are not possible:
https://github.com/reaper7/SDM_Energy_Meter/blob/master/SDM.cpp#L33

what do you think? Should I create a PR for IT?

@reaper7
Copy link
Owner

reaper7 commented Feb 14, 2023

Hi!
yes, of course, please create a PR, I will review it and add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants