Preprocessing of Hanging Nodes #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkolenz
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks for splitting up the code a bit and adding explanations to most of the functions! I added some review comments (mostly about making these changes consistent with the rest of the arguebuf code base). Could you please incorporate them?
Also, GitHub says that there is a merge conflict with this file. Could you investigate and resolve this as well?
Thanks!
mirkolenz
requested changes
Feb 1, 2024
Co-authored-by: Mirko Lenz <mirko@lenz.am>
Co-authored-by: Mirko Lenz <mirko@lenz.am>
…ocessHangingNodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.