-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprocessing of Hanging Nodes #102
Preprocessing of Hanging Nodes #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting up the code a bit and adding explanations to most of the functions! I added some review comments (mostly about making these changes consistent with the rest of the arguebuf code base). Could you please incorporate them?
Also, GitHub says that there is a merge conflict with this file. Could you investigate and resolve this as well?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the load flag is not ideal. I made a suggestion, do you think it is more intuitive?
Co-authored-by: Mirko Lenz <mirko@lenz.am>
Co-authored-by: Mirko Lenz <mirko@lenz.am>
…ocessHangingNodes
No description provided.