Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow style and data attributes in formatter (#57) #95

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Allow style and data attributes in formatter (#57) #95

merged 2 commits into from
Dec 16, 2023

Conversation

blms
Copy link
Contributor

@blms blms commented Dec 14, 2023

Hi @rsimon! Here's a PR to address the first two bullet points of #57.

Working with a client (eScriptorium) that uses recogito-js and needs colors pulled from an API endpoint dynamically applied to annotations, so we need to be able to pass the custom style attribute like in Annotorious.

The comments and some code were cribbed directly from Annotorious 😄

@rsimon
Copy link
Member

rsimon commented Dec 16, 2023

Hi @blms, looks great - thanks!

Great to hear that eScriptorium is using RecogitJS, BTW. I think I remember having discussions with them about it (quite a while back though). I'd be interested in hearing more about the type of content they are using it with. Also in terms of whether it might be possible to upgrade them to the successor library at some point?

@rsimon rsimon merged commit 451bd60 into recogito:main Dec 16, 2023
1 check passed
@blms blms deleted the blms/57-improved-formatter branch December 18, 2023 14:59
@blms
Copy link
Contributor Author

blms commented Dec 18, 2023

@rsimon They are using it with HTR transcription content, mostly (I believe) to mark metatextual things like insertions in marginalia. We will recommend the successor library upgrade to them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants