Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jittering positioning of the TextAnnotatorPopup on scroll #119

Closed
oleksandr-danylchenko opened this issue Jul 12, 2024 · 1 comment
Closed

Comments

@oleksandr-danylchenko
Copy link
Contributor

oleksandr-danylchenko commented Jul 12, 2024

Issue

When the text selection stops higher up in the content and then you start scrolling up/down, the popup starts to jump over the selection range:

sporadic_movement.mov

Personally, I find that kinda distracting, especially on smaller screen sizes:

Screen.Recording.2024-07-12.at.18.29.47.mov

Also, with autoPlacement the popup is constantly displayed over the annotated content

Suggested Changes

We can use a more temperate positioning like top + inline() middleware. Additionally, we can limit the crossAxis scrolling and let the user scroll from the popup. Which feels a bit more pleasant and intuitive (IMHO).

Existing solutions

The visual example I like is the Slab.com:
image
image

@oleksandr-danylchenko
Copy link
Contributor Author

Moreover, after I added the keyboard selection support in #118, I found that I could accidentally make the page freeze after pressing Ctrl+A. I narrowed it down to the popup positioning unable to find a suitable place and running into an endless loop.

rsimon added a commit that referenced this issue Jul 19, 2024
…-positioning-of-popup

#119 Tempered `TextAnnotatorPopup` positioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant