#133 Fixed missing annotation dismissal clicking outside of the annotator container (vol.2)
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-danylchenko
deleted the
#133-fix-not-dismissed-annotation-on-outside-click
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #133
Changes Made
To capture the actual
lastPointerDownevent on the page and make the correcttimeDifferencecalculations, I addedpointerdownevent to thedocumentscope.In that way, the "click" will be properly recognized in the
pointeruphandler and the selection will be dismissed. As there will be no annotation under the pointer.However, we should capture the
pointerdownonly on the elements that are not located within thenot-annotatabletree! Otherwise, it would be possible to unexpectedly dismiss the selected annotation while a user quickly drags from theinput/textarea/button, etc. onto the textual content!More details with demo - #135 (comment)