Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refract implementation #422

Closed
gottfriedleibniz opened this issue Jul 5, 2024 · 1 comment
Closed

refract implementation #422

gottfriedleibniz opened this issue Jul 5, 2024 · 1 comment
Labels
bug

Comments

@gottfriedleibniz
Copy link

Believe the current refract implementation is mixing up the signs. Referencing GLSL: $K = 1.0 - \mu^2 (1.0 - (N \boldsymbol{\cdot} I)^2)$, which would imply 1.0f - eta * eta + eni * eni; in code.
@recp
Copy link
Owner

recp commented Jul 15, 2024

Hi @gottfriedleibniz,

Sorry for the delay, thanks for the catch 🤗

48839a3 should fix that

@recp recp added the bug label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@recp @gottfriedleibniz