-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
ThrowWithPreviousExceptionRector.php
177 lines (175 loc) · 6.33 KB
/
ThrowWithPreviousExceptionRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
<?php
declare (strict_types=1);
namespace Rector\CodeQuality\Rector\Catch_;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Identifier;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt\Catch_;
use PhpParser\Node\Stmt\Throw_;
use PhpParser\NodeTraverser;
use PHPStan\Reflection\ParametersAcceptorSelector;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Type\ObjectType;
use PHPStan\Type\TypeWithClassName;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\MethodName;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\Catch_\ThrowWithPreviousExceptionRector\ThrowWithPreviousExceptionRectorTest
*/
final class ThrowWithPreviousExceptionRector extends AbstractRector
{
/**
* @readonly
* @var \PHPStan\Reflection\ReflectionProvider
*/
private $reflectionProvider;
/**
* @var int
*/
private const DEFAULT_EXCEPTION_ARGUMENT_POSITION = 2;
public function __construct(ReflectionProvider $reflectionProvider)
{
$this->reflectionProvider = $reflectionProvider;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('When throwing into a catch block, checks that the previous exception is passed to the new throw clause', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
try {
$someCode = 1;
} catch (Throwable $throwable) {
throw new AnotherException('ups');
}
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
try {
$someCode = 1;
} catch (Throwable $throwable) {
throw new AnotherException('ups', $throwable->getCode(), $throwable);
}
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Catch_::class];
}
/**
* @param Catch_ $node
*/
public function refactor(Node $node) : ?Node
{
$caughtThrowableVariable = $node->var;
if (!$caughtThrowableVariable instanceof Variable) {
return null;
}
$isChanged = \false;
$this->traverseNodesWithCallable($node->stmts, function (Node $node) use($caughtThrowableVariable, &$isChanged) : ?int {
if (!$node instanceof Throw_) {
return null;
}
$isChanged = $this->refactorThrow($node, $caughtThrowableVariable);
return $isChanged;
});
if (!(bool) $isChanged) {
return null;
}
return $node;
}
private function refactorThrow(Throw_ $throw, Variable $catchedThrowableVariable) : ?int
{
if (!$throw->expr instanceof New_) {
return null;
}
$new = $throw->expr;
if (!$new->class instanceof Name) {
return null;
}
$exceptionArgumentPosition = $this->resolveExceptionArgumentPosition($new->class);
if ($exceptionArgumentPosition === null) {
return null;
}
if ($new->isFirstClassCallable()) {
return null;
}
// exception is bundled
if (isset($new->getArgs()[$exceptionArgumentPosition])) {
return null;
}
if (!isset($new->getArgs()[0])) {
// get previous message
$getMessageMethodCall = new MethodCall($catchedThrowableVariable, 'getMessage');
$new->args[0] = new Arg($getMessageMethodCall);
}
/** @var Arg $messageArgument */
$messageArgument = $new->getArgs()[0];
$shouldUseNamedArguments = $messageArgument->name !== null;
if (!isset($new->getArgs()[1])) {
// get previous code
$new->args[1] = new Arg(new MethodCall($catchedThrowableVariable, 'getCode'), \false, \false, [], $shouldUseNamedArguments ? new Identifier('code') : null);
}
/** @var Arg $arg1 */
$arg1 = $new->args[1];
if ($arg1->name instanceof Identifier && $arg1->name->toString() === 'previous') {
$new->args[1] = new Arg(new MethodCall($catchedThrowableVariable, 'getCode'), \false, \false, [], $shouldUseNamedArguments ? new Identifier('code') : null);
$new->args[$exceptionArgumentPosition] = $arg1;
} else {
$new->args[$exceptionArgumentPosition] = new Arg($catchedThrowableVariable, \false, \false, [], $shouldUseNamedArguments ? new Identifier('previous') : null);
}
// null the node, to fix broken format preserving printers, see https://github.com/rectorphp/rector/issues/5576
$new->setAttribute(AttributeKey::ORIGINAL_NODE, null);
// nothing more to add
return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
}
private function resolveExceptionArgumentPosition(Name $exceptionName) : ?int
{
$className = $this->getName($exceptionName);
// is native exception?
if (\strpos($className, '\\') === \false) {
return self::DEFAULT_EXCEPTION_ARGUMENT_POSITION;
}
if (!$this->reflectionProvider->hasClass($className)) {
return self::DEFAULT_EXCEPTION_ARGUMENT_POSITION;
}
$classReflection = $this->reflectionProvider->getClass($className);
$construct = $classReflection->hasMethod(MethodName::CONSTRUCT);
if (!$construct) {
return self::DEFAULT_EXCEPTION_ARGUMENT_POSITION;
}
$extendedMethodReflection = $classReflection->getConstructor();
$parametersAcceptorWithPhpDocs = ParametersAcceptorSelector::combineAcceptors($extendedMethodReflection->getVariants());
foreach ($parametersAcceptorWithPhpDocs->getParameters() as $position => $parameterReflectionWithPhpDoc) {
$parameterType = $parameterReflectionWithPhpDoc->getType();
if (!$parameterType instanceof TypeWithClassName) {
continue;
}
$objectType = new ObjectType('Throwable');
if ($objectType->isSuperTypeOf($parameterType)->no()) {
continue;
}
return $position;
}
return null;
}
}