-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
ArrayMergeOfNonArraysToSimpleArrayRector.php
86 lines (82 loc) · 2.27 KB
/
ArrayMergeOfNonArraysToSimpleArrayRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
<?php
declare (strict_types=1);
namespace Rector\CodeQuality\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\ArrayItem;
use PhpParser\Node\Expr\FuncCall;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\FuncCall\ArrayMergeOfNonArraysToSimpleArrayRector\ArrayMergeOfNonArraysToSimpleArrayRectorTest
*/
final class ArrayMergeOfNonArraysToSimpleArrayRector extends AbstractRector
{
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Change array_merge of non arrays to array directly', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function go()
{
$value = 5;
$value2 = 10;
return array_merge([$value], [$value2]);
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function go()
{
$value = 5;
$value2 = 10;
return [$value, $value2];
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node) : ?Node
{
if (!$this->isName($node, 'array_merge')) {
return null;
}
$array = new Array_();
$isAssigned = \false;
foreach ($node->args as $arg) {
// found non Arg? return early
if (!$arg instanceof Arg) {
return null;
}
$nestedArrayItem = $arg->value;
if (!$nestedArrayItem instanceof Array_) {
return null;
}
foreach ($nestedArrayItem->items as $nestedArrayItemItem) {
if (!$nestedArrayItemItem instanceof ArrayItem) {
continue;
}
$array->items[] = $nestedArrayItemItem->unpack ? $nestedArrayItemItem : new ArrayItem($nestedArrayItemItem->value, $nestedArrayItemItem->key);
$isAssigned = \true;
}
}
if (!$isAssigned) {
return null;
}
return $array;
}
}