-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
CallUserFuncArrayToVariadicRector.php
114 lines (112 loc) · 3.52 KB
/
CallUserFuncArrayToVariadicRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
<?php
declare (strict_types=1);
namespace Rector\CodingStyle\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Scalar\String_;
use Rector\CodingStyle\NodeFactory\ArrayCallableToMethodCallFactory;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodingStyle\Rector\FuncCall\CallUserFuncArrayToVariadicRector\CallUserFuncArrayToVariadicRectorTest
*/
final class CallUserFuncArrayToVariadicRector extends AbstractRector implements MinPhpVersionInterface
{
/**
* @readonly
* @var \Rector\CodingStyle\NodeFactory\ArrayCallableToMethodCallFactory
*/
private $arrayCallableToMethodCallFactory;
/**
* @readonly
* @var \Rector\PhpParser\Node\Value\ValueResolver
*/
private $valueResolver;
public function __construct(ArrayCallableToMethodCallFactory $arrayCallableToMethodCallFactory, ValueResolver $valueResolver)
{
$this->arrayCallableToMethodCallFactory = $arrayCallableToMethodCallFactory;
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Replace call_user_func_array() with variadic', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
call_user_func_array('some_function', $items);
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
some_function(...$items);
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node) : ?Node
{
if (!$this->isName($node, 'call_user_func_array')) {
return null;
}
if ($node->isFirstClassCallable()) {
return null;
}
$firstArgValue = $node->getArgs()[0]->value;
$secondArgValue = $node->getArgs()[1]->value;
if ($firstArgValue instanceof String_) {
$functionName = $this->valueResolver->getValue($firstArgValue);
return $this->createFuncCall($secondArgValue, $functionName);
}
// method call
if ($firstArgValue instanceof Array_) {
return $this->createMethodCall($firstArgValue, $secondArgValue);
}
return null;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::ARRAY_SPREAD;
}
private function createFuncCall(Expr $expr, string $functionName) : FuncCall
{
$args = [$this->createUnpackedArg($expr)];
return $this->nodeFactory->createFuncCall($functionName, $args);
}
private function createMethodCall(Array_ $array, Expr $secondExpr) : ?MethodCall
{
$methodCall = $this->arrayCallableToMethodCallFactory->create($array);
if (!$methodCall instanceof MethodCall) {
return null;
}
$methodCall->args[] = $this->createUnpackedArg($secondExpr);
return $methodCall;
}
private function createUnpackedArg(Expr $expr) : Arg
{
return new Arg($expr, \false, \true);
}
}