-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
ConsistentImplodeRector.php
92 lines (90 loc) · 2.59 KB
/
ConsistentImplodeRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
<?php
declare (strict_types=1);
namespace Rector\CodingStyle\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Scalar\String_;
use Rector\NodeTypeResolver\TypeAnalyzer\StringTypeAnalyzer;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodingStyle\Rector\FuncCall\ConsistentImplodeRector\ConsistentImplodeRectorTest
*/
final class ConsistentImplodeRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\NodeTypeResolver\TypeAnalyzer\StringTypeAnalyzer
*/
private $stringTypeAnalyzer;
public function __construct(StringTypeAnalyzer $stringTypeAnalyzer)
{
$this->stringTypeAnalyzer = $stringTypeAnalyzer;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Changes various implode forms to consistent one', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run(array $items)
{
$itemsAsStrings = implode($items);
$itemsAsStrings = implode($items, '|');
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run(array $items)
{
$itemsAsStrings = implode('', $items);
$itemsAsStrings = implode('|', $items);
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node) : ?Node
{
if (!$this->isNames($node, ['implode', 'join'])) {
return null;
}
if ($node->isFirstClassCallable()) {
return null;
}
if (\count($node->getArgs()) === 1) {
// complete default value ''
$node->args[1] = $node->getArgs()[0];
$node->args[0] = new Arg(new String_(''));
return $node;
}
$firstArg = $node->getArgs()[0];
$firstArgumentValue = $firstArg->value;
$firstArgumentType = $this->getType($firstArgumentValue);
if ($firstArgumentType->isString()->yes()) {
return null;
}
if (\count($node->getArgs()) !== 2) {
return null;
}
$secondArg = $node->getArgs()[1];
if ($this->stringTypeAnalyzer->isStringOrUnionStringOnlyType($secondArg->value)) {
$node->args = \array_reverse($node->getArgs());
return $node;
}
return null;
}
}