-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
SymplifyQuoteEscapeRector.php
118 lines (116 loc) · 3.72 KB
/
SymplifyQuoteEscapeRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
<?php
declare (strict_types=1);
namespace Rector\CodingStyle\Rector\String_;
use PhpParser\Node;
use PhpParser\Node\Scalar\String_;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Rector\AbstractRector;
use Rector\Util\StringUtils;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodingStyle\Rector\String_\SymplifyQuoteEscapeRector\SymplifyQuoteEscapeRectorTest
*/
final class SymplifyQuoteEscapeRector extends AbstractRector
{
/**
* @var string
* @see https://regex101.com/r/qEkCe9/2
*/
private const ESCAPED_CHAR_REGEX = '#\\\\|\\$|\\n|\\t#sim';
/**
* @var string
* @see https://alvinalexander.com/php/how-to-remove-non-printable-characters-in-string-regex/
* @see https://regex101.com/r/lGUhRb/1
*/
private const HAS_NON_PRINTABLE_CHARS = '#[\\x00-\\x1F\\x80-\\xFF]#';
/**
* @var bool
*/
private $hasChanged = \false;
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Prefer quote that are not inside the string', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
$name = "\" Tom";
$name = '\' Sara';
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
$name = '" Tom';
$name = "' Sara";
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [String_::class];
}
/**
* @param String_ $node
*/
public function refactor(Node $node) : ?String_
{
$this->hasChanged = \false;
if (StringUtils::isMatch($node->value, self::HAS_NON_PRINTABLE_CHARS)) {
return null;
}
$doubleQuoteCount = \substr_count($node->value, '"');
$singleQuoteCount = \substr_count($node->value, "'");
$kind = $node->getAttribute(AttributeKey::KIND);
if ($kind === String_::KIND_SINGLE_QUOTED) {
$this->processSingleQuoted($node, $doubleQuoteCount, $singleQuoteCount);
}
$quoteKind = $node->getAttribute(AttributeKey::KIND);
if ($quoteKind === String_::KIND_DOUBLE_QUOTED) {
$this->processDoubleQuoted($node, $singleQuoteCount, $doubleQuoteCount);
}
if (!$this->hasChanged) {
return null;
}
return $node;
}
private function processSingleQuoted(String_ $string, int $doubleQuoteCount, int $singleQuoteCount) : void
{
if ($doubleQuoteCount === 0 && $singleQuoteCount > 0) {
// contains chars that will be newly escaped
if ($this->isMatchEscapedChars($string->value)) {
return;
}
$string->setAttribute(AttributeKey::KIND, String_::KIND_DOUBLE_QUOTED);
// invoke override
$string->setAttribute(AttributeKey::ORIGINAL_NODE, null);
$this->hasChanged = \true;
}
}
private function processDoubleQuoted(String_ $string, int $singleQuoteCount, int $doubleQuoteCount) : void
{
if ($singleQuoteCount === 0 && $doubleQuoteCount > 0) {
// contains chars that will be newly escaped
if ($this->isMatchEscapedChars($string->value)) {
return;
}
$string->setAttribute(AttributeKey::KIND, String_::KIND_SINGLE_QUOTED);
// invoke override
$string->setAttribute(AttributeKey::ORIGINAL_NODE, null);
$this->hasChanged = \true;
}
}
private function isMatchEscapedChars(string $string) : bool
{
return StringUtils::isMatch($string, self::ESCAPED_CHAR_REGEX);
}
}