-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
RemoveDuplicatedArrayKeyRector.php
123 lines (121 loc) · 3.68 KB
/
RemoveDuplicatedArrayKeyRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
<?php
declare (strict_types=1);
namespace Rector\DeadCode\Rector\Array_;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\ArrayItem;
use PhpParser\Node\Expr\PreDec;
use PhpParser\Node\Expr\PreInc;
use Rector\PhpParser\Printer\BetterStandardPrinter;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\Array_\RemoveDuplicatedArrayKeyRector\RemoveDuplicatedArrayKeyRectorTest
*/
final class RemoveDuplicatedArrayKeyRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\PhpParser\Printer\BetterStandardPrinter
*/
private $betterStandardPrinter;
public function __construct(BetterStandardPrinter $betterStandardPrinter)
{
$this->betterStandardPrinter = $betterStandardPrinter;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove duplicated key in defined arrays.', [new CodeSample(<<<'CODE_SAMPLE'
$item = [
1 => 'A',
1 => 'B'
];
CODE_SAMPLE
, <<<'CODE_SAMPLE'
$item = [
1 => 'B'
];
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Array_::class];
}
/**
* @param Array_ $node
*/
public function refactor(Node $node) : ?Node
{
$duplicatedKeysArrayItems = $this->resolveDuplicateKeysArrayItems($node);
if ($duplicatedKeysArrayItems === []) {
return null;
}
foreach ($node->items as $key => $arrayItem) {
if (!$arrayItem instanceof ArrayItem) {
continue;
}
if (!$this->isArrayItemDuplicated($duplicatedKeysArrayItems, $arrayItem)) {
continue;
}
unset($node->items[$key]);
}
return $node;
}
/**
* @return ArrayItem[]
*/
private function resolveDuplicateKeysArrayItems(Array_ $array) : array
{
$arrayItemsByKeys = [];
foreach ($array->items as $arrayItem) {
if (!$arrayItem instanceof ArrayItem) {
continue;
}
if (!$arrayItem->key instanceof Expr) {
continue;
}
$keyValue = $this->betterStandardPrinter->print($arrayItem->key);
$arrayItemsByKeys[$keyValue][] = $arrayItem;
}
return $this->filterItemsWithSameKey($arrayItemsByKeys);
}
/**
* @param array<mixed, ArrayItem[]> $arrayItemsByKeys
* @return array<ArrayItem>
*/
private function filterItemsWithSameKey(array $arrayItemsByKeys) : array
{
$duplicatedArrayItems = [];
foreach ($arrayItemsByKeys as $arrayItems) {
if (\count($arrayItems) <= 1) {
continue;
}
$currentArrayItem = \current($arrayItems);
/** @var Expr $currentArrayItemKey */
$currentArrayItemKey = $currentArrayItem->key;
if ($currentArrayItemKey instanceof PreInc) {
continue;
}
if ($currentArrayItemKey instanceof PreDec) {
continue;
}
// keep last one
\array_pop($arrayItems);
$duplicatedArrayItems = \array_merge($duplicatedArrayItems, $arrayItems);
}
return $duplicatedArrayItems;
}
/**
* @param ArrayItem[] $duplicatedKeysArrayItems
*/
private function isArrayItemDuplicated(array $duplicatedKeysArrayItems, ArrayItem $arrayItem) : bool
{
return \in_array($arrayItem, $duplicatedKeysArrayItems, \true);
}
}