-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
RemoveUnusedPrivateMethodParameterRector.php
225 lines (223 loc) · 7.57 KB
/
RemoveUnusedPrivateMethodParameterRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
<?php
declare (strict_types=1);
namespace Rector\DeadCode\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Param;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTagRemover;
use Rector\Comments\NodeDocBlock\DocBlockUpdater;
use Rector\DeadCode\NodeCollector\UnusedParameterResolver;
use Rector\DeadCode\NodeManipulator\VariadicFunctionLikeDetector;
use Rector\PhpParser\Node\BetterNodeFinder;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector\RemoveUnusedPrivateMethodParameterRectorTest
*/
final class RemoveUnusedPrivateMethodParameterRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\DeadCode\NodeManipulator\VariadicFunctionLikeDetector
*/
private $variadicFunctionLikeDetector;
/**
* @readonly
* @var \Rector\DeadCode\NodeCollector\UnusedParameterResolver
*/
private $unusedParameterResolver;
/**
* @readonly
* @var \Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTagRemover
*/
private $phpDocTagRemover;
/**
* @readonly
* @var \Rector\Comments\NodeDocBlock\DocBlockUpdater
*/
private $docBlockUpdater;
/**
* @readonly
* @var \Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory
*/
private $phpDocInfoFactory;
/**
* @readonly
* @var \Rector\PhpParser\Node\BetterNodeFinder
*/
private $betterNodeFinder;
public function __construct(VariadicFunctionLikeDetector $variadicFunctionLikeDetector, UnusedParameterResolver $unusedParameterResolver, PhpDocTagRemover $phpDocTagRemover, DocBlockUpdater $docBlockUpdater, PhpDocInfoFactory $phpDocInfoFactory, BetterNodeFinder $betterNodeFinder)
{
$this->variadicFunctionLikeDetector = $variadicFunctionLikeDetector;
$this->unusedParameterResolver = $unusedParameterResolver;
$this->phpDocTagRemover = $phpDocTagRemover;
$this->docBlockUpdater = $docBlockUpdater;
$this->phpDocInfoFactory = $phpDocInfoFactory;
$this->betterNodeFinder = $betterNodeFinder;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove unused parameter, if not required by interface or parent class', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
private function run($value, $value2)
{
$this->value = $value;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
private function run($value)
{
$this->value = $value;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node) : ?Node
{
$hasChanged = \false;
foreach ($node->getMethods() as $classMethod) {
if ($this->shouldSkipClassMethod($classMethod)) {
continue;
}
$unusedParameters = $this->unusedParameterResolver->resolve($classMethod);
if ($unusedParameters === []) {
continue;
}
$unusedParameterPositions = \array_keys($unusedParameters);
foreach (\array_keys($classMethod->params) as $key) {
if (!\in_array($key, $unusedParameterPositions, \true)) {
continue;
}
unset($classMethod->params[$key]);
}
// reset param keys
$classMethod->params = \array_values($classMethod->params);
$this->clearPhpDocInfo($classMethod, $unusedParameters);
$this->removeCallerArgs($node, $classMethod, $unusedParameters);
$hasChanged = \true;
}
if ($hasChanged) {
return $node;
}
return null;
}
/**
* @param Param[] $unusedParameters
*/
private function removeCallerArgs(Class_ $class, ClassMethod $classMethod, array $unusedParameters) : void
{
$classMethods = $class->getMethods();
if ($classMethods === []) {
return;
}
$methodName = $this->nodeNameResolver->getName($classMethod);
$keysArg = \array_keys($unusedParameters);
foreach ($classMethods as $classMethod) {
/** @var MethodCall[] $callers */
$callers = $this->resolveCallers($classMethod, $methodName);
if ($callers === []) {
continue;
}
foreach ($callers as $caller) {
$this->cleanupArgs($caller, $keysArg);
}
}
}
/**
* @param int[] $keysArg
*/
private function cleanupArgs(MethodCall $methodCall, array $keysArg) : void
{
if ($methodCall->isFirstClassCallable()) {
return;
}
$args = $methodCall->getArgs();
foreach (\array_keys($args) as $key) {
if (\in_array($key, $keysArg, \true)) {
unset($args[$key]);
}
}
// reset arg keys
$methodCall->args = \array_values($args);
}
/**
* @return MethodCall[]
*/
private function resolveCallers(ClassMethod $classMethod, string $methodName) : array
{
return $this->betterNodeFinder->find($classMethod, function (Node $subNode) use($methodName) : bool {
if (!$subNode instanceof MethodCall) {
return \false;
}
if ($subNode->isFirstClassCallable()) {
return \false;
}
if (!$subNode->var instanceof Variable) {
return \false;
}
if (!$this->nodeNameResolver->isName($subNode->var, 'this')) {
return \false;
}
return $this->nodeNameResolver->isName($subNode->name, $methodName);
});
}
private function shouldSkipClassMethod(ClassMethod $classMethod) : bool
{
if (!$classMethod->isPrivate()) {
return \true;
}
if ($classMethod->params === []) {
return \true;
}
return $this->variadicFunctionLikeDetector->isVariadic($classMethod);
}
/**
* @param Param[] $unusedParameters
*/
private function clearPhpDocInfo(ClassMethod $classMethod, array $unusedParameters) : void
{
$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($classMethod);
$hasChanged = \false;
foreach ($unusedParameters as $unusedParameter) {
$parameterName = $this->getName($unusedParameter->var);
if ($parameterName === null) {
continue;
}
$paramTagValueNode = $phpDocInfo->getParamTagValueByName($parameterName);
if (!$paramTagValueNode instanceof ParamTagValueNode) {
continue;
}
if ($paramTagValueNode->parameterName !== '$' . $parameterName) {
continue;
}
$hasTagRemoved = $this->phpDocTagRemover->removeTagValueFromNode($phpDocInfo, $paramTagValueNode);
if ($hasTagRemoved) {
$hasChanged = \true;
}
}
if ($hasChanged) {
$this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($classMethod);
}
}
}