-
-
Notifications
You must be signed in to change notification settings - Fork 680
/
RemoveDeadInstanceOfRector.php
167 lines (164 loc) · 5.16 KB
/
RemoveDeadInstanceOfRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
<?php
declare (strict_types=1);
namespace Rector\DeadCode\Rector\If_;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\CallLike;
use PhpParser\Node\Expr\Instanceof_;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\StaticPropertyFetch;
use PhpParser\Node\Name;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Expression;
use PhpParser\Node\Stmt\If_;
use PhpParser\NodeTraverser;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Type\MixedType;
use PHPStan\Type\ObjectType;
use Rector\NodeManipulator\IfManipulator;
use Rector\Rector\AbstractRector;
use Rector\Reflection\ReflectionResolver;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\If_\RemoveDeadInstanceOfRector\RemoveDeadInstanceOfRectorTest
*/
final class RemoveDeadInstanceOfRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\NodeManipulator\IfManipulator
*/
private $ifManipulator;
/**
* @readonly
* @var \Rector\Reflection\ReflectionResolver
*/
private $reflectionResolver;
public function __construct(IfManipulator $ifManipulator, ReflectionResolver $reflectionResolver)
{
$this->ifManipulator = $ifManipulator;
$this->reflectionResolver = $reflectionResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove dead instanceof check on type hinted variable', [new CodeSample(<<<'CODE_SAMPLE'
function run(stdClass $stdClass)
{
if (! $stdClass instanceof stdClass) {
return false;
}
return true;
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
function run(stdClass $stdClass)
{
return true;
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [If_::class];
}
/**
* @param If_ $node
* @return Stmt[]|null|int|If_
*/
public function refactor(Node $node)
{
if (!$this->ifManipulator->isIfWithoutElseAndElseIfs($node)) {
return null;
}
if ($node->cond instanceof BooleanNot && $node->cond->expr instanceof Instanceof_) {
return $this->refactorStmtAndInstanceof($node, $node->cond->expr);
}
if ($node->cond instanceof BooleanAnd) {
return $this->refactorIfWithBooleanAnd($node);
}
if ($node->cond instanceof Instanceof_) {
return $this->refactorStmtAndInstanceof($node, $node->cond);
}
return null;
}
/**
* @return null|Stmt[]|int
*/
private function refactorStmtAndInstanceof(If_ $if, Instanceof_ $instanceof)
{
if ($this->isInstanceofTheSameType($instanceof) !== \true) {
return null;
}
if ($this->shouldSkipFromNotTypedParam($instanceof)) {
return null;
}
if ($instanceof->expr instanceof Assign) {
$assignExpression = new Expression($instanceof->expr);
return \array_merge([$assignExpression], $if->stmts);
}
if ($if->cond !== $instanceof) {
return NodeTraverser::REMOVE_NODE;
}
if ($if->stmts === []) {
return NodeTraverser::REMOVE_NODE;
}
// unwrap stmts
return $if->stmts;
}
private function shouldSkipFromNotTypedParam(Instanceof_ $instanceof) : bool
{
$nativeParamType = $this->nodeTypeResolver->getNativeType($instanceof->expr);
return $nativeParamType instanceof MixedType;
}
private function isPropertyFetch(Expr $expr) : bool
{
if ($expr instanceof PropertyFetch) {
return \true;
}
return $expr instanceof StaticPropertyFetch;
}
private function isInstanceofTheSameType(Instanceof_ $instanceof) : ?bool
{
if (!$instanceof->class instanceof Name) {
return null;
}
// handled in another rule
if ($this->isPropertyFetch($instanceof->expr) || $instanceof->expr instanceof CallLike) {
return null;
}
$classReflection = $this->reflectionResolver->resolveClassReflection($instanceof);
if ($classReflection instanceof ClassReflection && $classReflection->isTrait()) {
return null;
}
$exprType = $this->nodeTypeResolver->getNativeType($instanceof->expr);
if (!$exprType instanceof ObjectType) {
return null;
}
$className = $instanceof->class->toString();
return $exprType->isInstanceOf($className)->yes();
}
private function refactorIfWithBooleanAnd(If_ $if) : ?\PhpParser\Node\Stmt\If_
{
if (!$if->cond instanceof BooleanAnd) {
return null;
}
$booleanAnd = $if->cond;
if (!$booleanAnd->left instanceof Instanceof_) {
return null;
}
$instanceof = $booleanAnd->left;
if ($this->isInstanceofTheSameType($instanceof) !== \true) {
return null;
}
$if->cond = $booleanAnd->right;
return $if;
}
}