-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
TernaryToBooleanOrFalseToBooleanAndRector.php
87 lines (83 loc) · 2.09 KB
/
TernaryToBooleanOrFalseToBooleanAndRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
<?php
declare (strict_types=1);
namespace Rector\DeadCode\Rector\Ternary;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
use PhpParser\Node\Expr\Ternary;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\Ternary\TernaryToBooleanOrFalseToBooleanAndRector\TernaryToBooleanOrFalseToBooleanAndRectorTest
*/
final class TernaryToBooleanOrFalseToBooleanAndRector extends AbstractRector
{
/**
* @readonly
* @var \Rector\PhpParser\Node\Value\ValueResolver
*/
private $valueResolver;
public function __construct(ValueResolver $valueResolver)
{
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Change ternary of bool : false to && bool', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function go()
{
return $value ? $this->getBool() : false;
}
private function getBool(): bool
{
return (bool) 5;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function go()
{
return $value && $this->getBool();
}
private function getBool(): bool
{
return (bool) 5;
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Ternary::class];
}
/**
* @param Ternary $node
*/
public function refactor(Node $node) : ?Node
{
if (!$node->if instanceof Expr) {
return null;
}
if (!$this->valueResolver->isFalse($node->else)) {
return null;
}
if ($this->valueResolver->isTrue($node->if)) {
return null;
}
$ifType = $this->getType($node->if);
if (!$ifType->isBoolean()->yes()) {
return null;
}
return new BooleanAnd($node->cond, $node->if);
}
}