-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
StaticCallOnNonStaticToInstanceCallRector.php
197 lines (193 loc) · 6.33 KB
/
StaticCallOnNonStaticToInstanceCallRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
<?php
declare (strict_types=1);
namespace Rector\Php70\Rector\StaticCall;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\StaticCall;
use PHPStan\Analyser\Scope;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\MethodReflection;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Type\ObjectType;
use Rector\CodingStyle\ValueObject\ObjectMagicMethods;
use Rector\Enum\ObjectReference;
use Rector\NodeCollector\ScopeResolver\ParentClassScopeResolver;
use Rector\NodeCollector\StaticAnalyzer;
use Rector\Rector\AbstractScopeAwareRector;
use Rector\Reflection\ReflectionResolver;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use ReflectionMethod;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Php70\Rector\StaticCall\StaticCallOnNonStaticToInstanceCallRector\StaticCallOnNonStaticToInstanceCallRectorTest
*/
final class StaticCallOnNonStaticToInstanceCallRector extends AbstractScopeAwareRector implements MinPhpVersionInterface
{
/**
* @readonly
* @var \Rector\NodeCollector\StaticAnalyzer
*/
private $staticAnalyzer;
/**
* @readonly
* @var \PHPStan\Reflection\ReflectionProvider
*/
private $reflectionProvider;
/**
* @readonly
* @var \Rector\Reflection\ReflectionResolver
*/
private $reflectionResolver;
/**
* @readonly
* @var \Rector\NodeCollector\ScopeResolver\ParentClassScopeResolver
*/
private $parentClassScopeResolver;
public function __construct(StaticAnalyzer $staticAnalyzer, ReflectionProvider $reflectionProvider, ReflectionResolver $reflectionResolver, ParentClassScopeResolver $parentClassScopeResolver)
{
$this->staticAnalyzer = $staticAnalyzer;
$this->reflectionProvider = $reflectionProvider;
$this->reflectionResolver = $reflectionResolver;
$this->parentClassScopeResolver = $parentClassScopeResolver;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::INSTANCE_CALL;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Changes static call to instance call, where not useful', [new CodeSample(<<<'CODE_SAMPLE'
class Something
{
public function doWork()
{
}
}
class Another
{
public function run()
{
return Something::doWork();
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class Something
{
public function doWork()
{
}
}
class Another
{
public function run()
{
return (new Something)->doWork();
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [StaticCall::class];
}
/**
* @param StaticCall $node
*/
public function refactorWithScope(Node $node, Scope $scope) : ?Node
{
if ($node->name instanceof Expr) {
return null;
}
$methodName = $this->getName($node->name);
$className = $this->resolveStaticCallClassName($node);
if ($methodName === null) {
return null;
}
if ($className === null) {
return null;
}
if ($this->shouldSkip($methodName, $className, $node, $scope)) {
return null;
}
if ($this->isInstantiable($className, $scope)) {
$new = new New_($node->class);
return new MethodCall($new, $node->name, $node->args);
}
return null;
}
private function resolveStaticCallClassName(StaticCall $staticCall) : ?string
{
if ($staticCall->class instanceof PropertyFetch) {
$objectType = $this->getType($staticCall->class);
if ($objectType instanceof ObjectType) {
return $objectType->getClassName();
}
}
return $this->getName($staticCall->class);
}
private function shouldSkip(string $methodName, string $className, StaticCall $staticCall, Scope $scope) : bool
{
if (\in_array($methodName, ObjectMagicMethods::METHOD_NAMES, \true)) {
return \true;
}
if (!$this->reflectionProvider->hasClass($className)) {
return \true;
}
$classReflection = $this->reflectionProvider->getClass($className);
if ($classReflection->isAbstract()) {
return \true;
}
// does the method even exist?
if (!$classReflection->hasMethod($methodName)) {
return \true;
}
$isStaticMethod = $this->staticAnalyzer->isStaticMethod($classReflection, $methodName);
if ($isStaticMethod) {
return \true;
}
$reflection = $scope->getClassReflection();
if ($reflection instanceof ClassReflection && $reflection->isSubclassOf($className)) {
return \true;
}
$className = $this->getName($staticCall->class);
if (\in_array($className, [ObjectReference::PARENT, ObjectReference::SELF, ObjectReference::STATIC], \true)) {
return \true;
}
if ($className === 'class') {
return \true;
}
$parentClassName = $this->parentClassScopeResolver->resolveParentClassName($scope);
return $className === $parentClassName;
}
private function isInstantiable(string $className, Scope $scope) : bool
{
if (!$this->reflectionProvider->hasClass($className)) {
return \false;
}
$methodReflection = $this->reflectionResolver->resolveMethodReflection($className, '__callStatic', $scope);
if ($methodReflection instanceof MethodReflection) {
return \false;
}
$classReflection = $this->reflectionProvider->getClass($className);
$nativeReflection = $classReflection->getNativeReflection();
$reflectionMethod = $nativeReflection->getConstructor();
if (!$reflectionMethod instanceof ReflectionMethod) {
return \true;
}
if (!$reflectionMethod->isPublic()) {
return \false;
}
// required parameters in constructor, nothing we can do
return !(bool) $reflectionMethod->getNumberOfRequiredParameters();
}
}