-
-
Notifications
You must be signed in to change notification settings - Fork 687
/
FirstClassCallableRector.php
150 lines (146 loc) · 5.35 KB
/
FirstClassCallableRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
<?php
declare (strict_types=1);
namespace Rector\Php81\Rector\Array_;
use PhpParser\Node;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\PropertyFetch;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt\ClassConst;
use PhpParser\Node\Stmt\Property;
use PhpParser\Node\VariadicPlaceholder;
use PhpParser\NodeTraverser;
use PHPStan\Analyser\Scope;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\ReflectionProvider;
use Rector\NodeCollector\NodeAnalyzer\ArrayCallableMethodMatcher;
use Rector\NodeCollector\ValueObject\ArrayCallable;
use Rector\Rector\AbstractScopeAwareRector;
use Rector\Reflection\ReflectionResolver;
use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
use Rector\ValueObject\PhpVersion;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Php81\Rector\Array_\FirstClassCallableRector\FirstClassCallableRectorTest
*/
final class FirstClassCallableRector extends AbstractScopeAwareRector implements MinPhpVersionInterface
{
/**
* @readonly
* @var \Rector\NodeCollector\NodeAnalyzer\ArrayCallableMethodMatcher
*/
private $arrayCallableMethodMatcher;
/**
* @readonly
* @var \PHPStan\Reflection\ReflectionProvider
*/
private $reflectionProvider;
/**
* @readonly
* @var \Rector\Reflection\ReflectionResolver
*/
private $reflectionResolver;
public function __construct(ArrayCallableMethodMatcher $arrayCallableMethodMatcher, ReflectionProvider $reflectionProvider, ReflectionResolver $reflectionResolver)
{
$this->arrayCallableMethodMatcher = $arrayCallableMethodMatcher;
$this->reflectionProvider = $reflectionProvider;
$this->reflectionResolver = $reflectionResolver;
}
public function getRuleDefinition() : RuleDefinition
{
// see RFC https://wiki.php.net/rfc/first_class_callable_syntax
return new RuleDefinition('Upgrade array callable to first class callable', [new CodeSample(<<<'CODE_SAMPLE'
final class SomeClass
{
public function run()
{
$name = [$this, 'name'];
}
public function name()
{
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
final class SomeClass
{
public function run()
{
$name = $this->name(...);
}
public function name()
{
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Property::class, ClassConst::class, Array_::class];
}
/**
* @param Property|ClassConst|Array_ $node
* @return int|null|\PhpParser\Node\Expr\StaticCall|\PhpParser\Node\Expr\MethodCall
*/
public function refactorWithScope(Node $node, Scope $scope)
{
if ($node instanceof Property || $node instanceof ClassConst) {
return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
}
$arrayCallable = $this->arrayCallableMethodMatcher->match($node, $scope);
if (!$arrayCallable instanceof ArrayCallable) {
return null;
}
$callerExpr = $arrayCallable->getCallerExpr();
if (!$callerExpr instanceof Variable && !$callerExpr instanceof PropertyFetch && !$callerExpr instanceof ClassConstFetch) {
return null;
}
$args = [new VariadicPlaceholder()];
if ($callerExpr instanceof ClassConstFetch) {
$type = $this->getType($callerExpr->class);
if ($type instanceof FullyQualifiedObjectType && $this->isNonStaticOtherObject($type, $arrayCallable, $scope)) {
return null;
}
return new StaticCall($callerExpr->class, $arrayCallable->getMethod(), $args);
}
$methodName = $arrayCallable->getMethod();
$methodCall = new MethodCall($callerExpr, $methodName, $args);
$classReflection = $this->reflectionResolver->resolveClassReflectionSourceObject($methodCall);
if ($classReflection instanceof ClassReflection && $classReflection->hasNativeMethod($methodName)) {
$method = $classReflection->getNativeMethod($methodName);
if (!$method->isPublic()) {
return null;
}
}
return $methodCall;
}
public function provideMinPhpVersion() : int
{
return PhpVersion::PHP_81;
}
private function isNonStaticOtherObject(FullyQualifiedObjectType $fullyQualifiedObjectType, ArrayCallable $arrayCallable, Scope $scope) : bool
{
$classReflection = $scope->getClassReflection();
if ($classReflection instanceof ClassReflection && $classReflection->getName() === $fullyQualifiedObjectType->getClassName()) {
return \false;
}
$arrayClassReflection = $this->reflectionProvider->getClass($arrayCallable->getClass());
// we're unable to find it
if (!$arrayClassReflection->hasMethod($arrayCallable->getMethod())) {
return \false;
}
$extendedMethodReflection = $arrayClassReflection->getMethod($arrayCallable->getMethod(), $scope);
if (!$extendedMethodReflection->isStatic()) {
return \true;
}
return !$extendedMethodReflection->isPublic();
}
}