Disable ECS somehow?

[aruku]

I would like to only commit the changes the code needs for going from one version of PHP to another. Fixing the style will be the done in the future.

Is there a way to prevent Rector from doing this? I installed ECS too and added the config file with no directories configured and skipping the whole path, but it still does it.
Can I overwrite Rector's ECS config?

[TomasVotruba]

Hi,
Rector and ECS are 2 seprated tools with separated responsibility. They have their own printer.

The best practice is to setup ECS first, apply sets on the whole codebase. Only then we add Rector.

[aruku]

@samsonasik is there a way to know what other rules are going to do that too?

[samsonasik]

You can search rules with set setAttribute(AttributeKey::ORIGINAL_NODE, null) that means reprint https://github.com/search?q=repo%3Arectorphp%2Frector%20ORIGINAL_NODE%2C%20null&type=code

[aruku]

Thank you both.

[aruku]

Just to confirm I'm not doing it wrong after spending the entire day dealing with this: there is no way to make Rector have ECS apply the right formatting after applying changes to make the code match another version of PHP, is there?
Meaning, to get from:

class X
{
    protected TokenStorageInterface $tokenStorage;
    protected Notifier $notifier;
    protected UrlGeneratorInterface $urlGenerator;
    protected MailerInterface $mailer;
    protected LoggerInterface $logger;
    protected TranslatorInterface $translator;
    protected EntityManagerInterface $em;

    public function __construct(TokenStorageInterface $tokenStorage, Notifier $notifier, UrlGeneratorInterface $urlGenerator, MailerInterface $mailer, LoggerInterface $logger, TranslatorInterface $translator, EntityManagerInterface $em)
    {
        $this->tokenStorage = $tokenStorage;
        $this->notifier = $notifier;
        $this->urlGenerator = $urlGenerator;
        $this->mailer = $mailer;
        $this->logger = $logger;
        $this->translator = $translator;
        $this->em = $em;
    }
}

to

class X
{
    public function __construct(
        protected TokenStorageInterface $tokenStorage,
        protected Notifier $notifier,
        protected UrlGeneratorInterface $urlGenerator,
        protected MailerInterface $mailer,
        protected LoggerInterface $logger,
        protected TranslatorInterface $translator,
        protected EntityManagerInterface $em
    ) {
    }
}

I need two steps: bin/rector and bin/ecs --fix, each with the appropriate configuration.

Is this correct?

[samsonasik]

Yes, you can run ecs after run rector as separate command run