Can't get AnnotationToAttribute to work.

[plandolt]

I have a symfony application and want to update all the Annotation-Route use statements with the new Attribute-Route use statement.

I installed rector in a subdirectory (tools/rector) but have my rector.php configuration in the top project level directory with that content:

$rectorConfig->paths([
    __DIR__.'/src',
]);

$rectorConfig->symfonyContainerXml(__DIR__.'/var/cache/dev/App_KernelDevDebugContainer.xml');

$rectorConfig->sets([
    SymfonySetList::ANNOTATIONS_TO_ATTRIBUTES,
]);

When I run:
tools/rector/vendor/bin/rector process --dry-run

I just get nothing:
[OK] Rector is done!

Do you have any hints to point me in the right direction?

[TomasVotruba]

Hi,

I'm thinking of possible requirements:

• composer must have 8.0+
• PHP version must have 8.0+
• Rector has to be installed as normal dependency, so autoload works
• the Symfony attributes must exist in /vendor, they're attribute only since specific Symfony version, not since PHP 8.0 only

If nothing helps, please share the rector.php and minimal reproducer repository on Github. We'll check it 👍

[plandolt]

I had PHP 8.2 on the webapp and the rector subdirectory. I then tried to install rector as a direct dev dependency to the webapp but still no luck. The attribute Class exists as I use symfony 6.4.

I created a small demo with a freshly installed symfony (--version=lts --webapp) here to test: https://github.com/scuben/rector-demo-issue-8384

vendor/bin/rector process --dry-run
[OK] Rector is done!

Despite https://github.com/scuben/rector-demo-issue-8384/blob/main/src/Controller/DummyController.php#L7 should be changed to the Attribute Version.

[TomasVotruba]

Thanks for sharing! We'll be able to figure this out soon 👍

It seems the https://github.com/scuben/rector-demo-issue-8384/blob/main@%7B2024-01-04T08:46:43Z%7D/src/Controller/DummyController.php#L11 is already an #[Attribute].

Could you send the link to the @annotation form?

[plandolt]

Ah, I might completely misunderstand the rule.

My goal is to change the use statement from use Symfony\Component\Routing\Annotation\Route; to use Symfony\Component\Routing\Attribute\Route;

Is there a rule for that kind of migration?

[samsonasik]

You can enable $rectorConfig->importNames() and the use statement will be replaced :)

[plandolt]

I updated the rector.php file but I still have no proposed changes. Do you have any idea why?

[samsonasik]

Are you sure you verify Symfony\Component\Routing\Annotation\Route to Symfony\Component\Routing\Attribute\Route registered in config and changed in the method?

[samsonasik]

I see, it seems because the method already use attribute, so it can't change to attribute again.

I suggest to use RenameClassRector to rename existing attribute.

[plandolt]

Great, that was the hint I needed. With the RenameClassRector I could achieve what I planned to do. Thank you for your support!

[TomasVotruba]

@scuben I see now, thanks for feedback.
I'll see how can we integrate it to attribute set itself to avoid this extra work.

Reopening for myself to fix this.