Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurly_js.php needs update for recurlyjs v3. #185

Closed
AlannaBurke opened this issue Sep 16, 2015 · 3 comments
Closed

Recurly_js.php needs update for recurlyjs v3. #185

AlannaBurke opened this issue Sep 16, 2015 · 3 comments
Assignees
Labels
V2 V2 Client

Comments

@AlannaBurke
Copy link

For Recurly.js v3, this whole class needs updating:
https://github.com/recurly/recurly-client-php/blob/master/lib/recurly/recurly_js.php
as does

For users on Recurly.js v3, it now uses a public key, and it's not 32 characters. I believe that's the extent of the changes that affect this file. I'm currently working to rework the Recurly Drupal module for Recurly.js v3, which uses this library, so I'd be happy to submit a PR when I've got it all done.

@bhelx bhelx self-assigned this Sep 22, 2015
@bhelx
Copy link
Contributor

bhelx commented Sep 22, 2015

Hey @AlannaBurke, you shouldn't need to use that class for recurly.js v3. Sorry if that wasn't clear. If you look at some php examples you can see that all you need to do is take your token that recurlyjs retrieved and pass it to your billing info object on the server side. From there it's all normal API stuff:

https://github.com/recurly/recurly-js-examples/blob/master/api/php/app.php#L30

Can you explain what you had in mind for changes to the recurly_js class?

@AlannaBurke
Copy link
Author

Okay, thanks - our existing code was setting up using Recurly_js::$privateKey, and i got started by just tweaking everything that was already there.

@bhelx
Copy link
Contributor

bhelx commented Sep 24, 2015

I'm going to go ahead and close this issue. Feel free to open if you don't think it's resolved or want to continue the conversation. And feel free to reach out to support or IRC if need need general advice about upgrading to r.js v3.

@bhelx bhelx closed this as completed Sep 24, 2015
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

No branches or pull requests

2 participants