-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coupon redemption issues #196
Comments
Hey sorry I'm not sure how this got missed. We're doing some other work with the PHP client's coupons so we can look into this as part of that. |
Hey @davidmcl The href on redemption is dependent on the recurly-client-php/lib/recurly/client.php Line 141 in 94dc6ce
So it should be returning plural. I believe if you do not set a header, it defaults to 2.0. In your curl request try setting that header to 2.1. Also, which version of the php library are you using? You should be able to get multiple redemptions as of version 2.4.6. Thanks for your patience. |
Thanks - I'll not get to check this out until after this weekend, but I was using code as of... I'll update to the latest build when I push out some other changes over the weekend and then retry the testing next week. ... and attached is a screenshot from the version of PHP client I'm using. -- cheers, dbm |
That's merged and released in https://github.com/recurly/recurly-client-php/releases/tag/2.5.1 so I'm going to close this. |
I have switched my test subdomain to allow multiple coupon redemptions per account and have run into a few issues in my testing; I believe likely with the api itself, not the PHP wrapper, but there doesn't seem to be an generic api repo for issues and since I use the php wrapper - here it goes.
If multiple redemptions are allowed, I would think that the link in the account lookup (accounts/xxx) for the
<redemption>
element should reference /redemptions - plural, not singular - so as to get all redemptions, not just the last.If I call the redemptions api endpoint directly, e.g.
I get a list of redemptions, but the uuid of the individual redemptions are missing and the link shows the singular
redemption
...unlike your sample responses in the docs...
Thanks,
David
The text was updated successfully, but these errors were encountered: