Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update subscriptions with usage based addons #240

Closed
ScottSpittle opened this issue Jun 22, 2016 · 4 comments
Closed

Cannot update subscriptions with usage based addons #240

ScottSpittle opened this issue Jun 22, 2016 · 4 comments
Assignees
Labels
bug V2 V2 Client

Comments

@ScottSpittle
Copy link

ScottSpittle commented Jun 22, 2016

Now using subscriptions with usage-based addons I am unable to update those subscriptions.

New subscription with no addons with the following code works fine.

$subscription = Recurly_Subscription::get('[subscriptions_code]');
$subscription->quantity = 2;
$subscription->updateImmediately();     // Update immediately.

New subscription with on-demand addon with the following code does not work.

$subscription = Recurly_Subscription::get('[subscriptions_code]');
$subscription->quantity = 2;
$subscription->updateImmediately();     // Update immediately.

I get the following error, "The provided XML was invalid."

@ScottSpittle ScottSpittle changed the title Cannot update subscriptions with addons Cannot update subscriptions with usage based addons Jun 22, 2016
@bhelx bhelx self-assigned this Jun 22, 2016
@bhelx
Copy link
Contributor

bhelx commented Jun 22, 2016

@ScottSpittle thanks a lot for reporting with code. I'm going to try to reproduce this today and see what the problem might be.

@bhelx bhelx added bug? bug and removed bug? labels Jun 22, 2016
@bhelx
Copy link
Contributor

bhelx commented Jun 22, 2016

@ScottSpittle I've identified what the problem is here. I'm going to get a PR out for review today and will link back here.

@bhelx
Copy link
Contributor

bhelx commented Jun 23, 2016

A quick update on this. I'm still looking at it but it's a little more delicate of a change than I initially thought. I hope to have something out today or tomorrow.

@bhelx
Copy link
Contributor

bhelx commented Jun 24, 2016

@ScottSpittle It's in master now and will go out in the next release. Will ping back here on the release PR. Please feel free to re-open if you think the conversation needs to go on.

@bhelx bhelx closed this as completed Jun 24, 2016
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V2 V2 Client
Projects
None yet
Development

No branches or pull requests

2 participants