Updating subscription with coupon code returns dot mark '.'

[mpietraszneurosys]

I found problem when I use coupon code. When I create new subscription with coupon everything is fine. When Im updating subscription to another plan with coupon I spot weird error. This code should update my subscription, set new plan code and add coupon when exists. When I enter coupon code I got this error:

Recurly_ValidationError: . in /var/www/vendor/recurly/recurly-client/lib/recurly/response.php on line 30

here is my code:

try {
    $subscription = Recurly_Subscription::get($active_subsciption);
    if($this->coupon) {
        $subscription->coupon_code = $this->coupon;
    }
    $subscription->plan_code = $this->license;
    $subscription->quantity = 1;
    $subscription->updateImmediately();
    return [
        'status' => 200,
        'subscription' => $subscription
    ];
}catch (Recurly_Error $e) {
    return [
        'status' => 400,
        'error' => "Error: ".$e->getMessage()
    ];
}

$e->getMessage() returns . (dot mark)
Im using string on $this->coupon

what do I do wrong ?

[drewish]

That is pretty odd. I'd stick a var_dump in at https://github.com/recurly/recurly-client-php/blob/master/lib/recurly/client.php#L171 and see what the body of the error response looks like. I wonder if there's just a problem parsing the error message out.

[bhelx]

Hey @mpietraszneurosys

I was able to reproduce this. The problem has to do with the format of the coupon error. In my case it looks like this:

<error>
  <symbol>subscription_must_change</symbol>
  <description>You must change the subscription in order to redeem a coupon.</description>
</error>

The problem is that this is a ValidationError but the xml is of the shape of a FieldError. The validation error parser needs to be able to handle both shapes of xml.

I'm working on a fix for this now. I also think this is related to #281 as they are experiencing the same thing when getting what appears to also be a coupon error.