Iterating over TransactionList returns null instead of object when retrieved from Invoice

[epixa]

When you retrieve an Invoice with Recurly_Invoice::get(), the resulting object has a TransactionList named "transactions". Despite the TransactionList clearly having Transaction objects, if you attempt to iterate over that list, null is returned for each transaction rather than the transaction object itself.

Code to recreate the issue (use your own invoice id):

<?php
// include recurly, set $invoiceNumber
$invoice = Recurly_Invoice::get($invoiceNumber);
foreach ($invoice->transactions as $transaction) {
    echo gettype($transaction);
}
// assuming 1 transaction
// expected result: object
// actual result: NULL

The commit that directly causes this bug is 6895c7f

[kainosnoema]

@epixa this is now fixed in the latest version (commit: 1bb87de).

[epixa]

Great to hear! Thanks.

[crystinutzaa]

@bhelx This issue was just re-introduced.

I can confirm that it worked just fine till yesterday around:[2022-08-09 02:26 pm] it started to happen.

foreach ($invoice->transactions as $transaction) {
    echo gettype($transaction);
}
// assuming 1 transaction
// expected result: object
// actual result: NULL

[bhelx]

Wow, a bug lurking in hiding for 10+ years! I'm no longer at Recurly. I think the best person to notify would be @douglasmiller .

[douglasmiller]

Thank you for letting us know about this, @crystinutzaa. Could you share what version of the php client you are using?

I have an idea what might be causing this to re-appear, but would like to confirm.

[crystinutzaa]

Hey @douglasmiller
We use "recurly/recurly-client": "2.12.*",

[douglasmiller]

@crystinutzaa, I cannot reproduce the issue with the given code using the latest version of the 2.12.x client.

However, I've seen similar issues in the dotnet client. This has something to do with a change to how we render empty elements so I will get that change reverted until we can discover what the root cause of this client issue is.

I'll keep you posted

[douglasmiller]

@crystinutzaa, we have reverted the change in the API and this should be fixed for you. Could you please confirm?

[crystinutzaa]

@douglasmiller confirmed! 🎉