BC Break 2.8 -> 2.9ff. not documented Recurly_Invoice#subscription -> Recurly_Invoice#subscriptions

[tolry]

Hi,

we just noticed after upgrading to 2.10 (from 2.8) that Recurly_Invoice#subscription was removed and Recurly_Invoice#subscriptions needs to be used now, see commit: 33b32c5

We use this to get the subscriptions UUID (via splitting getHref()) as reference in our persistence layer.

This change should probably be listed as BC Break in the release notes, right?

In our case we had to change the following

$invoice->subscription->getHref();
// to
$invoice->subscriptions->get()->current()->getHref();

regards,
Tobias

[drewish]

I'm sorry about that. Hopefully it didn't cause too much of an impact on your business before you tracked down the cause. You're right it definitely should have been called out. I appreciate you bring it to our attention.

I'll put in a ticket to make sure we get the change log and release notes updated to document that change. I think this was missed because it was a server side change that didn't require a client library change–aside from the docs updates that Dave noticed in a later release. We've tightened up the client library release process quite a bit since then so hopefully you won't encounter anything else like this going forward.

[bhelx]

@tolry Yeah, looks like my fault for not adding it to the changelog. Very sorry.

[tolry]

@drewish @bhelx thanks for the quick replies - no harm done on our side, this was only causing errors in worker jobs which we could simply reprocess, a bit of manual 'webhook resend clicking', that's all

[bhelx]

Thanks for taking the time to report though @tolry , it could save some others a lot of pain.