Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter case changes in HTTP/2 #391

Closed
billtomczak opened this issue Jan 3, 2019 · 4 comments
Closed

Letter case changes in HTTP/2 #391

billtomczak opened this issue Jan 3, 2019 · 4 comments
Assignees
Labels
V2 V2 Client

Comments

@billtomczak
Copy link

We recently found paging functions broken when cURL switched to using HTTP/2. It turns out the headers are sent with all lower case keys in http/2. Causing this to always return false due to capital-L Link::

if (isset($response->headers['Link'])) {

See:
https://github.com/recurly/recurly-client-php/blob/master/lib/recurly/pager.php#L132

@aaron-junot aaron-junot self-assigned this Jan 3, 2019
@aaron-junot
Copy link

Using curl, I have confirmed that the response headers are lower case

@billtomczak
Copy link
Author

Thanks Aaron! I have a patch in place in my application but it won't pass the unit tests because they insist on the upper-case header keys.

@aaron-junot
Copy link

If you would like to do a PR for the fix and update the unit test to accept the lower case header, I'd be happy to review and merge it!

@aaron-junot
Copy link

Fixed in #392

@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

No branches or pull requests

3 participants