Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading PHPUnit version #431

Closed
peter279k opened this issue Sep 20, 2019 · 1 comment · Fixed by #445
Closed

Consider upgrading PHPUnit version #431

peter279k opened this issue Sep 20, 2019 · 1 comment · Fixed by #445
Labels

Comments

@peter279k
Copy link

peter279k commented Sep 20, 2019

Changed log

  • Firstly, it's about the enhancement work.
    According to the official PHPUnit website, the PHPUnit versions support different PHP versions. For example, looking at following items:
    • The PHPUnit 5.x supports php-5.6 version at least.
    • The PHPUnit 6.x supports php-7.0 version at least.
    • The PHPUnit 7.x supports php-7.1 version at least.
    • The PHPUnit 8.x supports php-7.2 version at least.

To let unit test works executing successful, I suggest we can consider upgrading the PHPUnit version and defining multiple PHPUnit versions to support different PHP versions.

And the unit test development on this package will be good and reliable.

BTW, once this issue is accepted, I can work on that :).

@bhelx
Copy link
Contributor

bhelx commented Sep 20, 2019

This would be much appreciated! I'll happily review and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants