Invalid Argument Warning in coupon.php

[jeffchannell]

If $this->_links is empty in Recurly_Coupon a warning is displayed.

[drewish]

Can you say more about ho the object was getting initialized without that?

[jeffchannell]

I haven't nailed that down just yet, but will post more when I figure it out!

[drewish]

Awesome, your fix made sense but if there's an upstream cause, I'd love to try to fix that.

[jeffchannell]

It appears to be triggered by doing this (simplified):

$coupon = Recurly_Coupon::get('expired_coupon');
$coupon->redeemCoupon($account_code, 'USD');

I think this should trigger an Exception...

[drewish]

You can see the test triggering this error now: https://travis-ci.org/recurly/recurly-client-php/jobs/16490175