-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wandb-sweep example and clean-up use of configs #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than Config() object
@bengioe, it seemed harmless to me, but while cleaning up the config-use if the Tasks' main(), I moved qm9.py back with the other tasks. Not sure why historically it was the only task who had its own directory and config file but we should revert that if for some reason that was important. |
julienroyd
changed the title
Remove hps dictionnaries in favour of Config() objects + minor clean-ups
Add wandb-sweep example and clean-up use of configs
Feb 16, 2024
bengioe
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of both hps-dictionaries in the Task files was a bit difficult to manage alongside the Config() dataclass objects that were now becoming the norm inside the repo. The mix of both would:
Also added support for wandb:
GFNTrainer.log()
we simply check if a wandb.run is defined (whether wandb.init() has been called on the user side) and if so, we wandb.log() our metrics on the cloud too.