Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2094856: rbd: create token and use it for vault SA #98

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

nixpanic
Copy link
Member

create the token if kubernetes version in 1.24+ and use it for vault sa.

I hereby confirm that:

create the token if kubernetes version in
1.24+ and use it for vault sa.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Rakshith R <rar@redhat.com>
(cherry picked from commit 7a2dd4c)
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@nixpanic: This pull request references Bugzilla bug 2094856, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.11.0) matches configured target release for branch (ODF 4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2094856: rbd: create token and use it for vault SA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@nixpanic: This pull request references Bugzilla bug 2094856, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.11.0) matches configured target release for branch (ODF 4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2094856: rbd: create token and use it for vault SA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Its a good idea label Jun 17, 2022
@yati1998
Copy link
Member

@nixpanic please check the CI errors.

@nixpanic
Copy link
Member Author

@nixpanic please check the CI errors.

Those issues are unrelated to this change. There are upstream improvements/corrections to the jobs, but there is no BZ we can use for backporting those changes to the downstream release-4.11.

/assign yati1998

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@yati1998: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nixpanic, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yati1998
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@yati1998: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yati1998
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Jun 17, 2022
@openshift-ci openshift-ci bot merged commit 5fb8bda into red-hat-storage:release-4.11 Jun 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@nixpanic: All pull requests linked via external trackers have merged:

Bugzilla bug 2094856 has been moved to the MODIFIED state.

In response to this:

Bug 2094856: rbd: create token and use it for vault SA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rakshith-R
Copy link
Member

/cherry-pick release-4.10

@openshift-cherrypick-robot

@Rakshith-R: new pull request created: #99

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants