Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance method to fetch OSD list & Enable faster recovery during PG merge #4241

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Enhance method to fetch OSD list & Enable faster recovery during PG merge #4241

merged 2 commits into from
Nov 21, 2024

Conversation

harshkumarRH
Copy link
Contributor

PR addresses the following two changes:

  • Enhances existing method to fetch active OSDs to be able to provide list of OSD depending on the status argument provided by the user.
  • TFA fix for no-recover flag test case: Recently it was observed that test would timeout just as soon as desired number of PGs were reached, to enable faster recovery and PG split and merge, recovery flags are being modified and timeout has been slightly increased.

Signed-off-by: Harsh Kumar hakumar@redhat.com

@harshkumarRH harshkumarRH added RADOS Rados Core tfa-issue-fix TFA automation issue fix labels Nov 20, 2024
@harshkumarRH harshkumarRH self-assigned this Nov 20, 2024
@harshkumarRH
[RADOS] Enhance method to fetch list of OSDs
86a7a4d 
Signed-off-by: Harsh Kumar <hakumar@redhat.com>
@harshkumarRH
[RADOS] TFA fix: Enable faster recovery during PG decrease
58ae9fb 
Signed-off-by: Harsh Kumar <hakumar@redhat.com>
pdhiran
pdhiran reviewed Nov 21, 2024
View reviewed changes
tests/rados/test_norecovery_flag_functionality.py
)
time.sleep(10)
time.sleep(60)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for increasing the timeout. Will help with reducing log lines.

pdhiran
pdhiran reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@pdhiran pdhiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

pdhiran
pdhiran approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@pdhiran pdhiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Nov 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshkumarRH, pdhiran

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 403427b into red-hat-storage:master Nov 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdhiran pdhiran pdhiran approved these changes

@SrinivasaBharath SrinivasaBharath Awaiting requested review from SrinivasaBharath

@neha-gangadhar neha-gangadhar Awaiting requested review from neha-gangadhar

@s-vipin s-vipin Awaiting requested review from s-vipin

Assignees

@pdhiran pdhiran

@harshkumarRH harshkumarRH

Labels
lgtm Add this label when the PR is good to be merged RADOS Rados Core tfa-issue-fix TFA automation issue fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshkumarRH @pdhiran