Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role and ClusterRole #2

Closed
pierrevillard opened this issue Dec 14, 2021 · 2 comments · Fixed by #3
Closed

Role and ClusterRole #2

pierrevillard opened this issue Dec 14, 2021 · 2 comments · Fixed by #3

Comments

@pierrevillard
Copy link
Contributor

pierrevillard commented Dec 14, 2021 •
edited
Loading

Hi,

I noticed that file : https://github.com/pierreilki/ingress-dashboard/blob/master/ingress-dashboard.yaml declare a K8S Role and a ClusterRole, both binded to "ingress-dashboard" ServiceAccount. Does your application really need "ingress-dashboard" Role, and "ingress-dashboard" RoleBinding if a ClusterRole and a ClusterRoleBinding with sames rights are already declared and binded to your SA ?

If no, i can update this file :)
@reddec
Copy link
Owner

reddec commented Dec 14, 2021

CR and CRB should be enough, thanks!

Unfortunately we have to use Cluster kind of permissions due to watch in all namespaces

@pierrevillard pierrevillard mentioned this issue Dec 14, 2021
Merged
@pierrevillard
Copy link
Contributor Author

@reddec OK! :)

I opened a PR. Cluster Kind RBAC is normal for your app i think :)

Have a nice day

@reddec reddec closed this as completed in #3 Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused rights pierrevillard/ingress-dashboard
2 participants
@reddec @pierrevillard