Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError __LOGGER__({ label: "foo" }) is not a function #738

Closed
svassr opened this issue Nov 1, 2016 · 4 comments
Closed

TypeError __LOGGER__({ label: "foo" }) is not a function #738

svassr opened this issue Nov 1, 2016 · 4 comments
Assignees
Labels
bug An issue with the system

Comments

@svassr
Copy link

svassr commented Nov 1, 2016

I tried to use label for a logger like follow

var logger = logging.getLogger(__LOGGER__({ label: "foo" }));

I received that error about __LOGGER__ :

TypeError: (intermediate value)(intermediate value) is not a function

I'm using node v6.2.2 and the following modules

└── react@0.14.8
└── react-server@0.4.8 
└─┬ react-server-cli@0.4.9
  └── webpack@1.13.2 
@gigabo gigabo added the bug An issue with the system label Nov 1, 2016
@gigabo
Copy link
Contributor

gigabo commented Nov 1, 2016

Thanks for reporting @svassr. Are you using the React Server CLI to run your server?

@svassr
Copy link
Author

svassr commented Nov 2, 2016

Yes I am. I added the version up here

@gigabo
Copy link
Contributor

gigabo commented Nov 3, 2016

Ugh, yeah this is pretty broken. 😬

The __LOGGER__({ label: "foo" }) syntax is supported by react-server-module-tagger, but not the babel-plugin-react-server wrapper that the CLI uses. Totally unimplemented!

@gigabo
Copy link
Contributor

gigabo commented Dec 5, 2016

Oops, looks like this got auto-closed by #778, but it's not quite resolved yet.

The label key is getting passed through but not appended to the name.

There's some more discussion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

No branches or pull requests

3 participants