Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side hot module replacement does not work #970

Closed
salehhamadeh opened this issue Nov 9, 2017 · 0 comments · Fixed by #1003
Closed

Client-side hot module replacement does not work #970

salehhamadeh opened this issue Nov 9, 2017 · 0 comments · Fixed by #1003
Labels
bug An issue with the system
Milestone

Comments

@salehhamadeh
Copy link
Contributor

If you modify a file while react-server is running with hot: true, the server updates the file and the client receives the updated file (can be seen in the browser console), but the new component is not used. This broke down when we upgraded react-hot-loader to v3. We had to do this because react-hot-loader v1 depended on ReactMount, which is no longer supported in React 16. The new version of react-hot-loader requires us to tell a component how to render itself. This is shown in "Step 2: Using HMR to replace the root component" on react-hot-loader's Getting Started page http://gaearon.github.io/react-hot-loader/getstarted/

@gigabo gigabo added the bug An issue with the system label Nov 9, 2017
@drewpc drewpc added this to the 1.0 milestone Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants