Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator-react-server] Reference the correct file for the yeoman generator in package.json #966

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

negativetwelve
Copy link
Contributor

Hi there!

Instead of using the globally installed yeoman generator for this project, we're using a local version with yeoman-environment. When using the environment directly, we require this package in order to get a reference to the generator itself.

Unfortunately, the reference to the main in the package.json points to a file that doesn't exist. Everything seems to be fixed by fixing this one line :)

Let me know if this has any other implications. I don't think it should have any implications to the globally installed generator but I could be wrong.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2017

CLA assistant check
All committers have signed the CLA.

@negativetwelve negativetwelve changed the title [Generator] Reference the correct file for the yeoman generator in package.json [generator-react-server] Reference the correct file for the yeoman generator in package.json Oct 25, 2017
@gigabo gigabo added the bug An issue with the system label Nov 6, 2017
@gigabo
Copy link
Contributor

gigabo commented Nov 6, 2017

Thanks @negativetwelve!

@gigabo gigabo merged commit a972847 into redfin:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants