This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Devfile spec changes after eclipse/che feedbacks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garagatyi
approved these changes
Nov 9, 2018
| type: dockerImage | ||
| image: maven:3.5.4-jdk-8 | ||
| entryPoint: sleep infinity | ||
| persistentVolumes: |
There was a problem hiding this comment.
Do we need to call it persistentVolumes? Maybe simplify it to volumes?
There was a problem hiding this comment.
Good idea. It makes me think that for the dockerImage definition (and other 3rd party objects) we should try to reuse existing API as much as possible instead of reinventing ours.
sleshchenko
approved these changes
Nov 9, 2018
skabashnyuk
approved these changes
Nov 9, 2018
mshaposhnik
approved these changes
Nov 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes related to the comments on eclipse-che/che#11832