Merge 9e1e28a into dcd786d

cmd/odo/odo.go

@@ -10,12 +10,18 @@ import (
 	"github.com/redhat-developer/odo/pkg/odo/cli/version"
 	"github.com/redhat-developer/odo/pkg/odo/util"
 	"github.com/redhat-developer/odo/pkg/odo/util/completion"
+	"github.com/redhat-developer/odo/pkg/plugin"
 	"github.com/spf13/cobra"
 	"github.com/spf13/pflag"
 	"os"
+	"path/filepath"
+	"strings"
 )
 
 func main() {
+	loadPlugins()
+	defer plugin.CleanPlugins()
+
 	// create the complete command
 	root := cli.NewCmdOdo(cli.OdoRecommendedName, cli.OdoRecommendedName)
 	rootCmp := createCompletion(root)
@@ -112,3 +118,20 @@ func createCompletion(root *cobra.Command) complete.Command {
 
 	return rootCmp
 }
+
+func loadPlugins() {
+	configDir, err := config.GetPluginsDir()
+	if err != nil {
+		panic(err)
+	}
+
+	err = filepath.Walk(configDir, func(path string, info os.FileInfo, err error) error {
+		if strings.HasSuffix(path, ".listener.odo") {
+			plugin.InitPluginAt(path)
+		}
+		return nil
+	})
+	if err != nil {
+		panic(err)
+	}
+}

glide.yaml

@@ -49,6 +49,12 @@ import:
   version: v1.1.2
 - package: github.com/gobwas/glob
   version: e7a84e9525fe90abcda167b604e483cc959ad4aa
+- package: github.com/metacosm/odo-event-api
+  version: go-plugin
+- package: google.golang.org/grpc
+  version: ^1.12.0
+- package: golang.org/x/sys
+  version: master
 - package: github.com/openshift/origin
   version: v3.11.0
   subpackages:

pkg/config/config.go

@@ -62,6 +62,35 @@ type ConfigInfo struct {
 	Config
 }
 
+func GetConfigDir() (string, error) {
+	currentUser, err := user.Current()
+	if err != nil {
+		return "", err
+	}
+
+	configDir := filepath.Join(currentUser.HomeDir, ".odo")
+
+	// Check whether directory present or not
+	_, err = os.Stat(filepath.Dir(configDir))
+	if os.IsNotExist(err) {
+		err = os.MkdirAll(filepath.Dir(configDir), 0755)
+		if err != nil {
+			return "", err
+		}
+	}
+
+	return configDir, nil
+}
+
+func GetPluginsDir() (string, error) {
+	configDir, err := GetConfigDir()
+	if err != nil {
+		return "", err
+	}
+
+	return filepath.Join(configDir, "plugins"), nil
+}
+
 func getDefaultConfigFile() string {
 	currentUser, err := user.Current()
 	if err != nil {

pkg/odo/cli/catalog/describe/service.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 	"github.com/olekukonko/tablewriter"
 	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
-	odoutil "github.com/redhat-developer/odo/pkg/odo/util"
 	svc "github.com/redhat-developer/odo/pkg/service"
 	"github.com/spf13/cobra"
 	ktemplates "k8s.io/kubernetes/pkg/kubectl/cmd/templates"
@@ -136,9 +135,7 @@ func NewCmdCatalogDescribeService(name, fullName string) *cobra.Command {
 		Example: fmt.Sprintf(serviceExample, fullName),
 		Args:    cobra.ExactArgs(1),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(o.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(o.Validate(), "")
-			odoutil.LogErrorAndExit(o.Run(), "")
+			genericclioptions.GenericRun(o, cmd, args)
 		},
 	}
 

pkg/odo/cli/catalog/list/components.go

@@ -5,7 +5,6 @@ import (
 	"github.com/redhat-developer/odo/pkg/catalog"
 	"github.com/redhat-developer/odo/pkg/odo/cli/catalog/util"
 	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
-	odoutil "github.com/redhat-developer/odo/pkg/odo/util"
 	"github.com/spf13/cobra"
 	"os"
 	"strings"
@@ -86,9 +85,7 @@ func NewCmdCatalogListComponents(name, fullName string) *cobra.Command {
 		Long:    "List all available component types from OpenShift's Image Builder.",
 		Example: fmt.Sprintf(componentsExample, fullName),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(o.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(o.Validate(), "")
-			odoutil.LogErrorAndExit(o.Run(), "")
+			genericclioptions.GenericRun(o, cmd, args)
 		},
 	}
 

pkg/odo/cli/catalog/list/services.go

@@ -5,7 +5,6 @@ import (
 	"github.com/redhat-developer/odo/pkg/occlient"
 	"github.com/redhat-developer/odo/pkg/odo/cli/catalog/util"
 	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
-	odoutil "github.com/redhat-developer/odo/pkg/odo/util"
 	svc "github.com/redhat-developer/odo/pkg/service"
 	"github.com/spf13/cobra"
 )
@@ -64,9 +63,7 @@ func NewCmdCatalogListServices(name, fullName string) *cobra.Command {
 		Example: fmt.Sprintf(servicesExample, fullName),
 		Args:    cobra.ExactArgs(0),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(o.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(o.Validate(), "")
-			odoutil.LogErrorAndExit(o.Run(), "")
+			genericclioptions.GenericRun(o, cmd, args)
 		},
 	}
 }

pkg/odo/cli/catalog/search/component.go

@@ -5,7 +5,6 @@ import (
 	"github.com/redhat-developer/odo/pkg/catalog"
 	"github.com/redhat-developer/odo/pkg/log"
 	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
-	odoutil "github.com/redhat-developer/odo/pkg/odo/util"
 	"github.com/spf13/cobra"
 )
 
@@ -68,9 +67,7 @@ components.
 		Args:    cobra.ExactArgs(1),
 		Example: fmt.Sprintf(componentExample, fullName),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(o.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(o.Validate(), "")
-			odoutil.LogErrorAndExit(o.Run(), "")
+			genericclioptions.GenericRun(o, cmd, args)
 		},
 	}
 }

pkg/odo/cli/catalog/search/service.go

@@ -5,7 +5,6 @@ import (
 	"github.com/redhat-developer/odo/pkg/occlient"
 	"github.com/redhat-developer/odo/pkg/odo/cli/catalog/util"
 	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
-	odoutil "github.com/redhat-developer/odo/pkg/odo/util"
 	svc "github.com/redhat-developer/odo/pkg/service"
 	"github.com/spf13/cobra"
 )
@@ -71,9 +70,7 @@ services from service catalog.
 		Example: fmt.Sprintf(serviceExample, fullName),
 		Args:    cobra.ExactArgs(1),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(o.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(o.Validate(), "")
-			odoutil.LogErrorAndExit(o.Run(), "")
+			genericclioptions.GenericRun(o, cmd, args)
 		},
 	}
 

pkg/odo/cli/cli.go

@@ -3,7 +3,6 @@ package cli
 import (
 	"flag"
 	"fmt"
-
 	"github.com/redhat-developer/odo/pkg/odo/cli/application"
 	"github.com/redhat-developer/odo/pkg/odo/cli/catalog"
 	"github.com/redhat-developer/odo/pkg/odo/cli/component"
@@ -78,6 +77,7 @@ func NewCmdOdo(name, fullName string) *cobra.Command {
 		Long:    odoLong,
 		Example: fmt.Sprintf(odoExample, fullName),
 	}
+
 	// Here you will define your flags and configuration settings.
 	// Cobra supports persistent flags, which, if defined here,
 	// will be global for your application.

pkg/odo/cli/component/component.go

@@ -47,7 +47,7 @@ func NewCmdComponent(name, fullName string) *cobra.Command {
 		// 'odo component' is the same as 'odo component get'
 		// 'odo component <component_name>' is the same as 'odo component set <component_name>'
 		Run: func(cmd *cobra.Command, args []string) {
-			if len(args) > 0 && args[0] != "get" && args[0] != "set" {
+			if len(args) > 0 && args[0] != RecommendedGetCommandName && args[0] != RecommendedSetCommandName {
 				componentSetCmd.Run(cmd, args)
 			} else {
 				componentGetCmd.Run(cmd, args)

pkg/odo/cli/component/create.go

@@ -371,9 +371,7 @@ func NewCmdCreate(name, fullName string) *cobra.Command {
 		Example: fmt.Sprintf(createExample, fullName),
 		Args:    cobra.RangeArgs(1, 2),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(co.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(co.Validate(), "")
-			odoutil.LogErrorAndExit(co.Run(), "")
+			genericclioptions.GenericRun(co, cmd, args)
 		},
 	}
 	componentCreateCmd.Flags().StringVarP(&co.componentBinary, "binary", "b", "", "Use a binary as the source file for the component")

pkg/odo/cli/component/delete.go

@@ -2,6 +2,7 @@ package component
 
 import (
 	"fmt"
+	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
 	"strings"
 
 	"github.com/pkg/errors"
@@ -104,9 +105,7 @@ func NewCmdDelete(name, fullName string) *cobra.Command {
 		Example: fmt.Sprintf(deleteExample, fullName),
 		Args:    cobra.MaximumNArgs(1),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(do.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(do.Validate(), "")
-			odoutil.LogErrorAndExit(do.Run(), "")
+			genericclioptions.GenericRun(do, cmd, args)
 		},
 	}
 

pkg/odo/cli/component/describe.go

@@ -2,6 +2,7 @@ package component
 
 import (
 	"fmt"
+	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
 
 	"encoding/json"
 
@@ -123,9 +124,7 @@ func NewCmdDescribe(name, fullName string) *cobra.Command {
 		Example: fmt.Sprintf(describeExample, fullName),
 		Args:    cobra.RangeArgs(0, 1),
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(do.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(do.Validate(), "")
-			odoutil.LogErrorAndExit(do.Run(), "")
+			genericclioptions.GenericRun(do, cmd, args)
 		},
 	}
 

pkg/odo/cli/component/get.go

@@ -8,7 +8,6 @@ import (
 	appCmd "github.com/redhat-developer/odo/pkg/odo/cli/application"
 	"github.com/redhat-developer/odo/pkg/odo/cli/project"
 	"github.com/redhat-developer/odo/pkg/odo/genericclioptions"
-	odoutil "github.com/redhat-developer/odo/pkg/odo/util"
 	"github.com/spf13/cobra"
 	ktemplates "k8s.io/kubernetes/pkg/kubectl/cmd/templates"
 )
@@ -71,9 +70,7 @@ func NewCmdGet(name, fullName string) *cobra.Command {
 		Example: fmt.Sprintf(getExample, fullName),
 		Args:    cobra.NoArgs,
 		Run: func(cmd *cobra.Command, args []string) {
-			odoutil.LogErrorAndExit(gto.Complete(name, cmd, args), "")
-			odoutil.LogErrorAndExit(gto.Validate(), "")
-			odoutil.LogErrorAndExit(gto.Run(), "")
+			genericclioptions.GenericRun(gto, cmd, args)
 		},
 	}