Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component.SetCurrent(name string) should error out if setting to component that doesn't exist #127

Closed
kadel opened this issue Feb 26, 2018 · 6 comments
Closed

component.SetCurrent(name string) should error out if setting to component that doesn't exist #127

kadel opened this issue Feb 26, 2018 · 6 comments
Assignees
@cdrage
Labels
estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@kadel
Copy link
Member

kadel commented Feb 26, 2018 •
edited
Loading

component.SetCurrent(name string) should error out if setting to component that doesn't exis

Currently, it is not erroring out because component.List() is not yet implemented (#53).
When we add it, it should be used in component.SetCurrent(name string) to verify that component that is requested to be set as current actually exists.
@ashetty1
Copy link
Contributor

The issue below because of this, I assume.

# ocdev component delete nodejs
buildconfig "nodejs" deleted
imagestream "nodejs" deleted
deploymentconfig "nodejs" deleted
pod "nodejs-1-24d6r" deleted
service "nodejs" deleted

# ocdev component get
The current component is: nodejs

@kadel
Copy link
Member Author

kadel commented Feb 28, 2018

@ashetty1 not really,
what you are describing is a different issue (#50), that should be fixed once #126 is merged

@kadel kadel added kind/task priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Apr 4, 2018
@kadel
Copy link
Member Author

kadel commented Apr 4, 2018

component.List was implemented, so we can proceed with this

This was referenced Apr 4, 2018
Closed
Closed
@kadel kadel added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). and removed priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Apr 5, 2018
@cdrage cdrage self-assigned this Apr 11, 2018
@cdrage
Copy link
Member

cdrage commented Apr 11, 2018 •
edited
Loading

I've assigned this to myself and started the work here: https://github.com/cdrage/ocdev/tree/check-setcurrent-exists

@kadel kadel mentioned this issue Apr 16, 2018
Closed
@concaf
Copy link
Contributor

concaf commented Apr 17, 2018

Hey @cdrage, I think this should be a pretty similar approach as in #384

@mik-dass mik-dass mentioned this issue Apr 18, 2018
Merged
@cdrage
Copy link
Member

cdrage commented Apr 23, 2018 •
edited
Loading

Closed via: #388

@cdrage cdrage closed this as completed Apr 23, 2018
@rm3l rm3l added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Jun 18, 2023
@rm3l rm3l added this to odo Project Jun 18, 2023
@rm3l rm3l moved this to Done ✅ in odo Project Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
odo Project
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kadel @rm3l @cdrage @concaf @ashetty1