Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo dev on podman and cluster cannot run simultaneously #6494

Closed
9 tasks done
Tracked by #6578
valaparthvi opened this issue Jan 16, 2023 · 4 comments · Fixed by #6713
Closed
9 tasks done
Tracked by #6578

odo dev on podman and cluster cannot run simultaneously #6494

valaparthvi opened this issue Jan 16, 2023 · 4 comments · Fixed by #6713
Assignees
Labels
area/dev Issues or PRs related to `odo dev` area/odo-on-podman Issues or PRs related to running odo against Podman priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Milestone

Comments

@valaparthvi
Copy link
Contributor

valaparthvi commented Jan 16, 2023

/kind bug

What versions of software are you using?

Operating System:
Fedora 35
Output of odo version:
odo v3.5.0 (da9a9ef)

How did you run odo exactly?

  1. odo init --devfile go --name my-go-app --starter go-starter
  2. ODO_EXPERIMENTAL_MODE=true odo dev --platform podman wait for it to finish
  3. In another tab odo dev.

Actual behavior

Once odo dev starts, both the dev sessions continue to sync because of the changes in .odo/devstate.json and never reach a stable state.

Expected behavior

Both sessions should be able to run and reach a stable state.

Any logs, error output, etc?

I am not sure if this is a valid use case and if something like this is an ideal workflow but it still a nuisance as an odo developer when I want to build and test new features for both podman and cluster.

Acceptance criteria

  • PID is added to the content of the devstate file
  • Platform is added to the content of the devstate file
  • Forwarded Ports are added to the content of the devstate file
  • each odo dev session creates its own devstate.$PID.json file
  • the first odo dev session also creates a devstate.json file, for compatibility.
  • each odo dev session should check if devstate.json file exists and references a PID not existing, it deletes it; this helps in cleaning any file lying around when the previous process was kill(9)-ed. Same for all odo commands reading this file (odo describe component, ...)
  • odo describe component displays forwarded ports from all devstate.$PID.json files
  • odo describe component --platform <platform> displays forwarded ports from devstate.$PID.json file with platform=<platform>
  • odo dev can run only once per platform, exit if a devstate.$PID.json file with the platform already exists.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2023
@valaparthvi valaparthvi removed the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2023
@rm3l rm3l added this to odo Project Jan 16, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 16, 2023
@feloy
Copy link
Contributor

feloy commented Jan 16, 2023

#6362 should fix the problem, but is not related to running on both platforms.

@kadel kadel added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). area/dev Issues or PRs related to `odo dev` area/odo-on-podman Issues or PRs related to running odo against Podman labels Mar 10, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 23, 2023
@rm3l
Copy link
Member

rm3l commented Mar 30, 2023

Grooming (2023-03-30)

  • Have one devstate.json file per Dev session PID

@feloy feloy self-assigned this Apr 4, 2023
@feloy feloy moved this to In Progress 🚧 in odo Project Apr 4, 2023
@valaparthvi
Copy link
Contributor Author

/status blocked
#6719

@feloy
Copy link
Contributor

feloy commented Apr 6, 2023

The implementation for checking if a PID exists is different on Windows and Unix, and needs some attention (do we want to run tests on Windows with Podman + Kubernetes?)

@valaparthvi valaparthvi added the sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint. label Apr 6, 2023
@valaparthvi valaparthvi moved this from In Progress 🚧 to In Review 👀 in odo Project Apr 11, 2023
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 12, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in odo Project Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev Issues or PRs related to `odo dev` area/odo-on-podman Issues or PRs related to running odo against Podman priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants